Skip to content

fix(knowledge): remove caution triangle overlay from connector icon - #6717

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/connector-icon-triangle
Aug 15, 2026
Merged

fix(knowledge): remove caution triangle overlay from connector icon#6717
waleedlatif1 merged 1 commit into
stagingfrom
fix/connector-icon-triangle

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the caution triangle badge overlaid on the connector icon in the Connected Sources modal when a connector is disabled
  • Collapse the now-redundant relative wrapper so the icon tile is a single element
  • The disabled state is still conveyed by the "Disabled" badge and the callout below

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 14, 2026 11:52pm

Request Review

@cursor

cursor Bot commented Aug 14, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Pure UI/layout change in the knowledge connectors list with no sync, auth, or data logic touched.

Overview
Removes the caution triangle badge that was overlaid on the connector icon in Connected Sources when a connector is disabled, and flattens the icon markup by dropping the extra relative wrapper so the tile is one element.

Disabled connectors are still indicated by the Disabled status badge and the existing callout below the row (with reconnect/resume guidance).

Reviewed by Cursor Bugbot for commit 40a6685. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes the caution triangle overlay from disabled connector icons while preserving the existing disabled badge and callout.

  • Collapses the redundant nested icon wrapper into one element.
  • Preserves icon dimensions, centering, border, background, and flex behavior.

Confidence Score: 5/5

The PR appears safe to merge with no actionable issues identified.

The simplified connector icon tile preserves the previous dimensions, centering, styling, and flex behavior while removing only the intentionally retired warning overlay.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/connectors-section/connectors-section.tsx Removes the disabled-state warning overlay and simplifies its wrapper without changing the connector tile’s layout behavior.

Reviews (1): Last reviewed commit: "fix(knowledge): remove caution triangle ..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit 638f389 into staging Aug 15, 2026
30 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/connector-icon-triangle branch August 15, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant