Skip to content

fix(icons): align table block icon and 12-unit icon stroke with the emcn family - #6708

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/chat-table-icon
Aug 14, 2026
Merged

fix(icons): align table block icon and 12-unit icon stroke with the emcn family#6708
waleedlatif1 merged 1 commit into
stagingfrom
fix/chat-table-icon

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The table/table_v2 blocks and the table trigger used a local lucide-shaped TableIcon (stroke 2.0, full-bleed 0 0 24 24, 3x3 grid) while the sidebar, Tables page, resource registry, @-mention menu, and folders all used emcn's Table (stroke 1.55, inset viewBox, header row + one divider). Most visible in Chat, where an agent group's header icon and its nested tool row rendered two different table glyphs side by side.
  • Deleted TableIcon from components/icons.tsx and pointed every consumer at @sim/emcn/icons Table — blocks, trigger, and 6 landing-page workflow mocks. Regenerated the two auto-generated icon maps.
  • Nested tool-call rows applied no color class, so a non-brand block icon inherited body text instead of --text-icon and read darker than its own label. Brand icons are unaffected: getBareIconStyle's inline color still wins for single-fill marks, and multi-color marks hardcode their own fills.
  • redo/undo/zoom-in/zoom-out draw strokeWidth 0.85 on a 12-unit viewBox, rendering 0.992px at a 14px box against the family's 0.904px (+9.7%). Set to 0.775 for exact parity — 170/171 stroked icon exports now render at identical weight (blimp, the brand mark, is the intentional exception).

Notes

  • Block icons change wherever the Table block appears — canvas, block picker, integrations page — not just the Chat row. That is the intent of consolidating on one glyph.
  • generate-docs's resolveIconSource matches the pre-as import specifier, so an aliased Table as TableIcon in a block silently emits a broken import into the generated icon maps. Blocks import it unaliased, matching mysql.ts/imap.ts/ssh.ts.

Type of Change

  • Bug fix

Testing

Tested manually. bun run type-check clean on apps/sim and packages/emcn; bun run lint clean. Stroke-weight parity verified by re-measuring every icon export after the change.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1
fix(icons): align table block icon and 12-unit icon stroke with the e…
f8bd2c8 
…mcn family

The table/table_v2 blocks and the table trigger used a local lucide-shaped
TableIcon (stroke 2.0, full-bleed 24 viewBox, 3x3 grid) while every other
table surface used emcn's Table. Consolidate onto the emcn icon and drop the
local copy.

Nested tool-call rows in Chat applied no color class, so a non-brand block
icon inherited body text instead of --text-icon.

redo/undo/zoom-in/zoom-out draw 0.85 stroke on a 12-unit viewBox, rendering
0.992px at a 14px box against the family's 0.904px. 0.775 restores parity.
@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Building Building Preview Aug 14, 2026 9:44pm

Request Review

@cursor

cursor Bot commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown

PR Summary

Low Risk
Visual-only icon consolidation and CSS color on tool rows; no auth, data, or runtime logic changes.

Overview
Consolidates the Table block on the shared emcn Table glyph and tightens stroke weight on a few 12-unit toolbar icons.

The local Lucide-style TableIcon (thick stroke, full-grid look) is removed from components/icons.tsx. table / table_v2 blocks, the table trigger, docs/integrations icon maps, and landing-page workflow mocks now use @sim/emcn/icons Table, matching the sidebar, Tables UI, and other surfaces. Auto-generated icon-mapping files point table at Table from emcn instead of the deleted export.

In Chat, nested tool-call rows add text-[var(--text-icon)] on block icons so non-brand glyphs align with icon color instead of inheriting body text; brand marks still follow getBareIconStyle.

redo, undo, zoom-in, and zoom-out change stroke width from 0.85 to 0.775 on their 12×12 viewBoxes so rendered weight matches the rest of the stroked emcn set at typical sizes.

Reviewed by Cursor Bugbot for commit f8bd2c8. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR consolidates table-related surfaces on the EMCN Table icon, applies the standard icon-color token to nested tool-call rows, and normalizes four 12-unit icon stroke widths.

  • Removes duplicate local TableIcon implementations and updates block, trigger, landing-page, documentation, and integration-map consumers.
  • Adds --text-icon styling to nested tool-call icons while preserving inline and hardcoded brand colors.
  • Adjusts redo, undo, zoom-in, and zoom-out stroke widths from 0.85 to 0.775.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified in the changed icon imports, styling, generated mappings, or SVG definitions.

The removed exports have no remaining local consumers, the shared EMCN icon satisfies existing component contracts, generated-map behavior remains intentional, and the color and stroke changes preserve the relevant rendering semantics.

Important Files Changed
Filename Overview
apps/sim/components/icons.tsx Removes the duplicate local table glyph after all consumers migrate to the EMCN icon export.
apps/sim/blocks/blocks/table.ts Changes the table block’s icon reference to the shared EMCN Table component without altering block behavior.
apps/sim/blocks/blocks/table_v2.ts Changes the preview table block’s icon reference to the same shared EMCN component.
apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/agent-group/tool-call-item.tsx Applies the theme-aware icon text token while retaining inline brand-color precedence.
apps/sim/lib/integrations/icon-mapping.ts Regenerates the integration icon map to reference the shared EMCN table icon.
apps/docs/components/ui/icon-mapping.ts Regenerates the documentation icon map to reference the shared EMCN table icon.
packages/emcn/src/icons/redo.tsx Reduces both path stroke widths for visual parity with the icon family.
packages/emcn/src/icons/undo.tsx Reduces both path stroke widths for visual parity with the icon family.
packages/emcn/src/icons/zoom-in.tsx Uniformly reduces all zoom-in glyph stroke widths.
packages/emcn/src/icons/zoom-out.tsx Uniformly reduces all zoom-out glyph stroke widths.

Reviews (1): Last reviewed commit: "fix(icons): align table block icon and 1..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit d5701d5 into staging Aug 14, 2026
29 of 30 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/chat-table-icon branch August 14, 2026 21:49
@waleedlatif1 waleedlatif1 mentioned this pull request Aug 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1