Skip to content

Revert "fix(integrations): read every service mark from one registry" - #6707

Merged
waleedlatif1 merged 1 commit into
stagingfrom
revert-6682-fix/integration-icon-registry
Aug 14, 2026
Merged

Revert "fix(integrations): read every service mark from one registry"#6707
waleedlatif1 merged 1 commit into
stagingfrom
revert-6682-fix/integration-icon-registry

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Reverts #6682

@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 14, 2026 9:47pm

Request Review

@cursor

cursor Bot commented Aug 14, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Mostly visual and icon-resolution refactors with no auth or data-model changes; risk is inconsistent branding on ambiguous OAuth services (the bridge that refused shared ids was removed) and regression in copilot mention UX if the restored hooks diverge from current chat behavior.

Overview
Reverts the change that routed integration and OAuth surfaces through a single block-registry path for icons and brand tiles (#6682).

Integration & OAuth UI no longer resolves marks via resolveIntegrationBlockTypeForOAuth or BlockTile in the connect OAuth modal header—the modal uses the service/provider icon from OAUTH_PROVIDERS again. IntegrationTile now requires a passed icon prop; list and detail pages supply icons from blockTypeToIconMap instead of auto-resolving from the block registry. The standalone ProviderIcon and knowledge-base ConnectorTile components are removed; connector pickers render inlined brand-colored tiles, and credential rows fall back to a plain letter tile when no display icon exists.

Credential selectors inline OAUTH_PROVIDERS icons (with bare brand styling in the editor path) rather than ProviderIcon. ChipModalHeader again only accepts icon components, not pre-rendered elements like brand tiles.

Suggested actions pins Slack/Gmail with SlackIcon/GmailIcon on first paint instead of registry-driven getBlockTileIcon. Add-resource dropdown passes bgColor on integration items for menu rendering.

Copilot user input restores a large @-mention stack (FOLDER_CONFIGS, useMentionData, keyboard/caret/insert hooks, textarea overlay sync)—foldered mentions for chats, workflows, knowledge, blocks, integrations, and logs.

Smaller cleanups: table workflow-output column headers carry color on BlockIconInfo again; log/terminal/toolbar paths use local grays instead of shared DEFAULT_BLOCK_TILE_COLOR / VARIABLE_TILE_COLOR; permission-group UI uses inline colored squares instead of BlockTile.

Reviewed by Cursor Bugbot for commit 651e38a. Configure here.

@waleedlatif1
waleedlatif1 merged commit 9664e7e into staging Aug 14, 2026
21 of 22 checks passed
@waleedlatif1
waleedlatif1 deleted the revert-6682-fix/integration-icon-registry branch August 14, 2026 21:41
@greptile-apps

greptile-apps Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR reverts the centralized service-mark registry change, restoring prior icon mappings, tile rendering, OAuth presentation, and copilot mention utilities.

  • Restores static integration icon mapping and per-surface brand styling.
  • Restores the expanded copilot mention data, keyboard, insertion, caret, and textarea hooks.
  • Reverts shared OAuth-to-block icon resolution and narrows ChipModalHeader icons back to component types.
  • Restores local color constants and icon rendering across tables, logs, workflow panels, connectors, and access control.

Confidence Score: 4/5

The PR appears safe to merge from a runtime perspective, with non-blocking TypeScript and styling convention violations to address.

No reachable functional or security failure was established, but the restored mention implementation uses pervasive explicit any types and several restored tile components use prohibited inline styles.

Files Needing Attention: apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/copilot/components/user-input/constants.ts, apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/copilot/components/user-input/hooks/use-mention-data.ts, apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/copilot/components/user-input/hooks/use-mention-keyboard.ts, apps/sim/app/workspace/[workspaceId]/integrations/components/integrations-showcase/integrations-showcase.tsx

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/copilot/components/user-input/constants.ts Restores the folder-driven mention and slash-command configuration, but uses an explicitly untyped generic item default.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/copilot/components/user-input/hooks/use-mention-data.ts Restores mention data loading and workflow-block synchronization with several explicit any types and casts.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/copilot/components/user-input/hooks/use-mention-keyboard.ts Restores keyboard navigation and dispatch for root, aggregated, and folder mention menus, while erasing folder item types.
apps/sim/app/workspace/[workspaceId]/integrations/components/integrations-showcase/integrations-showcase.tsx Restores required explicit icon props and dynamic branded backgrounds, including prohibited inline styles.
apps/sim/lib/integrations/oauth-service.ts Removes the OAuth-identity-to-integration-block bridge added by the reverted change.
packages/emcn/src/components/chip-modal/chip-modal.tsx Narrows modal-header icons from rendered elements or component types back to component types only.

Reviews (1): Last reviewed commit: "Revert "fix(integrations): read every se..." | Re-trigger Greptile

title: string
/** Data source key in useMentionData return */
dataKey: string
/** Loading state key in useMentionData return */

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Mention configuration erases item types

The restored mention-menu implementation uses explicit any types across folder configuration, data mapping, and insertion handlers. This prevents TypeScript from detecting mismatches between each folder's data, filter, context builder, and handler; use concrete item unions, generics, or unknown with type guards instead.

Context Used: TypeScript conventions and type safety (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!


if (!framed) {
return (
<div

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Brand tiles use inline styles

The restored integration and connector tiles apply dynamic backgrounds through JSX style props, bypassing the repository's required Tailwind styling convention. The same pattern occurs in the framed tile and the restored integration-detail and connector-card surfaces.

Context Used: Tailwind CSS and styling conventions (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant