Skip to content

fix(v2): close seven correctness and honesty gaps found sweeping the API #6702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 4 commits into from
Aug 14, 2026
Merged

fix(v2): close seven correctness and honesty gaps found sweeping the API #6702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31631f9
fix(v2): close seven correctness and honesty gaps found sweeping the API
waleedlatif1 Aug 14, 2026
eb50a58
fix(v2): correct three regressions this branch introduced, and harden…
waleedlatif1 Aug 14, 2026
c4e6abb
fix(execution): report a workflow-group cancellation as the write it …
waleedlatif1 Aug 14, 2026
f86d733
fix(execution): have a workflow-group cancellation report the writes …
waleedlatif1 Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/docs/openapi-v2-billing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@
"schema": {
"description": "Workspace whose payer should be resolved. Workspace API keys are pinned to their own workspace.",
"type": "string",
"minLength": 1
"minLength": 1,
"maxLength": 128
}
}
],
Expand Down Expand Up @@ -133,7 +134,8 @@
"schema": {
"description": "Restrict results to one workspace whose payer the caller can inspect.",
"type": "string",
"minLength": 1
"minLength": 1,
"maxLength": 128
}
},
{
Expand Down
35 changes: 34 additions & 1 deletion apps/docs/openapi-v2-files-audit.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace whose files should be listed."
}
},
Expand Down Expand Up @@ -343,6 +344,7 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the upload session."
}
},
Expand Down Expand Up @@ -433,6 +435,7 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the upload session."
}
},
Expand Down Expand Up @@ -537,6 +540,7 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the upload session."
}
},
Expand Down Expand Up @@ -629,6 +633,7 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the file."
}
}
Expand Down Expand Up @@ -721,6 +726,7 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the file."
}
}
Expand Down Expand Up @@ -965,8 +971,21 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the file."
}
},
{
"name": "scope",
"in": "query",
"required": false,
"description": "Which lifecycle set to read from: `active` (default) resolves live files only and returns `404` for a file a `DELETE` soft-deleted; `archived` also resolves soft-deleted files, so metadata stays readable before `POST /files/{fileId}/restore`. Authorization is identical for both.",
"schema": {
"default": "active",
"description": "Which lifecycle set to read from: `active` (default) resolves live files only and returns `404` for a file a `DELETE` soft-deleted; `archived` also resolves soft-deleted files, so metadata stays readable before `POST /files/{fileId}/restore`. Authorization is identical for both.",
"type": "string",
"enum": ["active", "archived"]
}
}
],
"responses": {
Expand Down Expand Up @@ -1060,7 +1079,8 @@
"schema": {
"description": "Filter to actions in one workspace.",
"type": "string",
"minLength": 1
"minLength": 1,
"maxLength": 128
}
},
{
Expand Down Expand Up @@ -1361,6 +1381,7 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the file."
}
}
Expand Down Expand Up @@ -1655,6 +1676,7 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace whose folders should be listed."
}
},
Expand Down Expand Up @@ -1898,6 +1920,7 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace containing the folder."
}
},
Expand Down Expand Up @@ -2437,6 +2460,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace in which to create the file."
},
"name": {
Expand Down Expand Up @@ -2651,6 +2675,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace in which the file will be registered."
},
"name": {
Expand Down Expand Up @@ -2822,6 +2847,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the file."
},
"name": {
Expand Down Expand Up @@ -2877,6 +2903,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the archived file."
}
},
Expand Down Expand Up @@ -3352,6 +3379,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace containing the files."
},
"fileIds": {
Expand Down Expand Up @@ -3446,6 +3474,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the file."
},
"isActive": {
Expand Down Expand Up @@ -3496,6 +3525,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the file."
},
"content": {
Expand Down Expand Up @@ -3572,6 +3602,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace containing the files."
},
"fileIds": {
Expand Down Expand Up @@ -3683,6 +3714,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace in which to create the folder."
},
"path": {
Expand All @@ -3701,6 +3733,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace containing the folder."
},
"path": {
Expand Down
15 changes: 15 additions & 0 deletions apps/docs/openapi-v2-knowledge.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace whose knowledge bases should be listed."
}
},
Expand Down Expand Up @@ -885,6 +886,7 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the knowledge base."
}
}
Expand Down Expand Up @@ -1077,6 +1079,7 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the knowledge base."
}
},
Expand Down Expand Up @@ -1178,6 +1181,7 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the knowledge base."
}
},
Expand Down Expand Up @@ -1293,6 +1297,7 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the knowledge base."
}
},
Expand Down Expand Up @@ -1635,6 +1640,7 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace whose folders should be listed."
}
},
Expand Down Expand Up @@ -1881,6 +1887,7 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace containing the folder."
}
},
Expand Down Expand Up @@ -2469,6 +2476,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace in which to create the knowledge base."
},
"name": {
Expand Down Expand Up @@ -2509,6 +2517,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the knowledge base."
},
"name": {
Expand Down Expand Up @@ -2798,6 +2807,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the knowledge bases."
},
"knowledgeBaseIds": {
Expand Down Expand Up @@ -3116,6 +3126,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the knowledge base."
},
"operation": {
Expand Down Expand Up @@ -3467,6 +3478,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the knowledge base."
},
"name": {
Expand Down Expand Up @@ -3918,6 +3930,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace that owns the knowledge base."
},
"filename": {
Expand Down Expand Up @@ -4113,6 +4126,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace in which to create the folder."
},
"path": {
Expand All @@ -4131,6 +4145,7 @@
"workspaceId": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace containing the folder."
},
"path": {
Expand Down
1 change: 1 addition & 0 deletions apps/docs/openapi-v2-logs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 128,
"description": "Workspace whose execution logs should be returned."
}
},
Expand Down
Loading
Loading