-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix(workflows): honor explicit canonical modes #6677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BillLeoutsakosvl346
wants to merge
1
commit into
staging
Choose a base branch
from
fix/canonical-selector-mode-resolution
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 17 additions & 12 deletions
29
...omponents/panel/components/editor/components/sub-block/hooks/use-dependency-block-type.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,24 @@ | ||
| 'use client' | ||
|
|
||
| import { createContext, useContext } from 'react' | ||
| import type { CanonicalModeOverrides } from '@/lib/workflows/subblocks/visibility' | ||
|
|
||
| const DependencyBlockTypeContext = createContext<string | null>(null) | ||
| export interface DependencyBlockContextValue { | ||
| blockType: string | ||
| canonicalModeOverrides: CanonicalModeOverrides | undefined | ||
| } | ||
|
|
||
| /** | ||
| * Provider set by tool-input param rendering (value = the tool's block type, e.g. `gmail`). | ||
| */ | ||
| const DependencyBlockTypeContext = createContext<DependencyBlockContextValue | null>(null) | ||
|
|
||
| /** Provides a nested tool's block type and already-scoped canonical modes. */ | ||
| export const DependencyBlockTypeProvider = DependencyBlockTypeContext.Provider | ||
|
|
||
| /** | ||
| * The block type whose config should drive dependency (`dependsOn`) canonical resolution | ||
| * for the current subblock. Null for normal blocks (resolve against the host block). Set | ||
| * to the tool's type for tool-input params, so a nested tool's selector resolves its | ||
| * parents against the TOOL's config (e.g. a Gmail tool's `credential` -> `oauthCredential`, | ||
| * which the host Agent block's subblocks don't define) and can fetch its options. | ||
| */ | ||
| export const useDependencyBlockType = () => useContext(DependencyBlockTypeContext) | ||
| export const useDependencyBlockContext = () => useContext(DependencyBlockTypeContext) | ||
|
|
||
| export function getDependencyCanonicalModeOverrides( | ||
| context: DependencyBlockContextValue | null, | ||
| hostOverrides: CanonicalModeOverrides | undefined | ||
| ): CanonicalModeOverrides | undefined { | ||
| // A nested tool with no scoped mode must use legacy inference, not another tool's host keys. | ||
| return context ? context.canonicalModeOverrides : hostOverrides | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.