Skip to content

improvement(copilot): clarify VFS tool-call titles - #6675

Open
j15z wants to merge 1 commit into
mship-fixesfrom
fix/vfs-tool-titles
Open

improvement(copilot): clarify VFS tool-call titles#6675
j15z wants to merge 1 commit into
mship-fixesfrom
fix/vfs-tool-titles

Conversation

@j15z

@j15z j15z commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Glob: Finding <model-authored title> / Finding files → Exploring Internal Knowledge Base / Explored Internal Knowledge Base.
  • Grep: Searching for <model-authored title> / Searching → path-aware copy such as Skimming Docs Page: workflows/agent, Searching Q4 Report for revenue, or Searching Internal Knowledge Base for BYOK.
  • Docs reads: generic filename copy such as Reading agent → Reading Docs Page: workflows/agent.
  • Page fetch: Getting / Got → Fetching / Fetched.

Streaming and settled rows now use the same labels. This UI-only change leaves executable tool contracts untouched.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: UI copy refinement

Testing

  • 97 focused tool-display, read-label, and streaming-title tests pass.
  • Repository-wide type-check passes (23 packages).
  • Repository-wide lint passes (23 packages).
  • API validation audit passes.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

N/A — the text-only chip behavior is covered across streaming, persisted, and fallback display paths; no layout changed.

@vercel

vercel Bot commented Aug 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 13, 2026 8:22pm

Request Review

@cursor

cursor Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown

PR Summary

Low Risk
Presentation-only changes to client-side title derivation; tool contracts and execution paths are untouched.

Overview
Copilot tool rows now use fixed, path-aware labels for VFS reads and searches instead of model-authored toolTitle snippets. glob always shows Exploring Internal Knowledge Base; grep uses Skimming Docs Page: … for docs paths or Searching <target> for <pattern> elsewhere; read on docs/… paths shows Docs Page: section/page.

web_fetch copy switches from Getting to Fetching / Fetched. Live streaming titles for glob and grep are routed through the same getToolDisplayTitle logic as settled rows so wording stays aligned while arguments stream in.

Reviewed by Cursor Bugbot for commit 950992b. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR standardizes Copilot VFS activity labels across streaming and settled tool-call rows.

  • Derives grep labels from the searched path and pattern instead of model-authored summaries.
  • Adds concise labels for documentation reads and searches.
  • Uses deterministic internal-knowledge labels for glob operations.
  • Changes page retrieval wording from “Getting” to “Fetching” and adds matching completed verbs.
  • Extends focused tests for streaming, persisted, and status-specific labels.

Confidence Score: 5/5

The PR appears safe to merge with no concrete blocking or independently actionable non-blocking issue identified.

The streaming and settled display paths converge on the same deterministic formatter, the changes remain UI-only, and focused tests cover the principal resource and status variants.

Important Files Changed
Filename Overview
apps/sim/lib/copilot/tools/tool-display.ts Centralizes deterministic grep, glob, docs-page, and web-fetch labels and adds corresponding completed-verb rewrites.
apps/sim/app/workspace/[workspaceId]/home/hooks/stream/stream-helpers.ts Reuses shared argument extraction and title formatting so streaming grep and glob labels align with settled rows.
apps/sim/lib/copilot/tools/client/store-utils.ts Formats reads under the docs corpus as concise Docs Page labels.
apps/sim/lib/copilot/tools/tool-display.test.ts Covers deterministic grep, glob, docs, fetch, and completed-state wording.
apps/sim/app/workspace/[workspaceId]/home/hooks/stream/turn-model-serialize.test.ts Verifies streaming VFS labels, including escaped patterns and docs paths.
apps/sim/lib/copilot/tools/client/store-utils.test.ts Verifies executing, successful, and failed docs-read labels.

Reviews (1): Last reviewed commit: "improvement(copilot): clarify VFS tool-c..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@j15z