perf(workspace): stop the sidebar fetching palette data on every route - #6670

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Aug 13, 2026 8:34pm

PR Summary

Medium Risk
Changes cold-load query timing and React Query cache keys across many workspace routes; incorrect hydration or permission gating in the palette could cause missing files in search or extra client waterfalls, but there is no direct auth or data-mutation risk.

Overview
Cmd+K palette data is no longer loaded from the persistent sidebar. Tables, knowledge bases, workspace files, and the table/KB folder maps are queried inside SearchModal only while the palette is open (enabled / undefined workspace id), with permission-tab hides applied in memos so cached data cannot leak into hidden sections.

Workspace file list SSR seeding moves off the layout sidebar prefetch into seedWorkspaceFiles (300-file budget, seed nothing on overflow or failed reads). Home and chat pages add HydrationBoundary + prefetchHomeSurface; Files prefetch calls the same seed. Routes like workflow editor, logs, and settings no longer pay for that list or register its query key on every load—so those pages can hydrate a seeded list when they actually need it.

Tests split file-seed behavior into seed-workspace-files.test.ts and flip layout/sidebar expectations (no file list read on sidebar prefetch; Files prefetch seeds it).

^{Reviewed by Cursor Bugbot for commit c43c934. Configure here.}

Greptile Summary

The PR moves palette-only queries out of the persistent workspace sidebar and relocates workspace-file hydration to the pages that consume it.

• Tables, files, knowledge bases, and their folder maps now load when the command palette opens.
• Home, chat, and Files surfaces seed their own workspace-file data through page-level hydration boundaries.
• The workspace layout no longer reads and serializes the file list for unrelated routes.
• File-list seeding is extracted into a bounded, failure-tolerant helper with focused tests.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

sequenceDiagram
  participant User
  participant Sidebar
  participant Palette as Cmd+K Palette
  participant QueryCache as React Query Cache
  participant API

  Sidebar->>Sidebar: Render on workspace route
  Note over Sidebar,API: Palette-only lists remain deferred
  User->>Palette: Open Cmd+K
  Palette->>QueryCache: Request tables, files, knowledge bases, folder maps
  alt Data is cached and fresh
    QueryCache-->>Palette: Return cached lists
  else Data is absent or stale
    QueryCache->>API: Fetch palette data
    API-->>QueryCache: Return lists and folder maps
    QueryCache-->>Palette: Render searchable entities
  end

_{Reviews (6): Last reviewed commit: "fix(chat): guard the chat page prefetch ..." | Re-trigger Greptile}

@greptile

@cursor review

Researched the registration problem properly and found the clean fix — it needed no mounting changes at all.

SearchModal is already a thin shell:

export function SearchModal({ open, ...props }: SearchModalProps) {
  const [mounted, setMounted] = useState(false)
  useEffect(() => { setMounted(true) }, [])
  if (!mounted || !open) return null
  return <SearchModalContent {...props} />
}

SearchModalContent only exists while the palette is open, and it already derives workspaceId from useParams() and reads usePermissionConfig(). So the five queries and their three memos moved there and needed no new props — the component that uses the data now owns fetching it.

That is strictly better than the enabled: false gating it replaces. Verified in the query-core source why: useBaseQuery builds its observer in a useState initializer unconditionally, the constructor calls #updateQuery() → queryCache.build() → add(), with no enabled check on that path. A disabled query does not fetch, but it still registers — which both leaves the key in the cache on routes that never show it and blocks a page from seeding that key during the server render, since HydrationBoundary defers an already-registered query to an effect SSR never runs.

Now nothing registers those keys unless the palette is open. Also removed four imports the move orphaned in sidebar.tsx, and updated the search-modal test to drive the Tables section through the mocked hook rather than the removed prop.

Deliberately not in this PR: moving the file-list seed out of the layout onto /files, /home, and /chat. That is now unblocked and is the remaining waste — the layout still seeds a list that only those three routes render. I want this premise confirmed in CI and staging first, since my previous attempt at the seed move rested on an assumption about enabled that turned out to be wrong.

@greptile

@cursor review

@greptile

@cursor review

@greptile

@cursor review

@greptile

@cursor review