Skip to content

fix(agent): show files in tool picker - #6666

Open
j15z wants to merge 2 commits into
stagingfrom
fix/files-not-in-agent-block-tools
Open

fix(agent): show files in tool picker#6666
j15z wants to merge 2 commits into
stagingfrom
fix/files-not-in-agent-block-tools

Conversation

@j15z

@j15z j15z commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • add the current file_v5 block to the Agent tool picker
  • classify file_v5—rather than legacy file—as a built-in tool
  • centralize Agent tool eligibility around visible integration tools and an explicit allowlist of supported core blocks
  • remove the redundant legacy exclusion list; legacy File remains hidden, while the registry MCP and Evaluator blocks remain outside the positive allowlist
  • add regression coverage for File eligibility and built-in classification

Dynamic tools fetched from configured MCP servers use a separate picker path and are unaffected.

Type of Change

  • Bug fix

Testing

  • 90 targeted tests passed
  • bun run lint
  • block registry audit
  • all 26 repository audits

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 13, 2026 7:13pm

Request Review

@cursor

cursor Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown

PR Summary

Low Risk
Localized UI/tool-picker and block-type classification changes with tests; no auth, data, or execution-path changes.

Overview
Fixes the Agent tool picker so the current File block (file_v5) can be selected, while the legacy file block stays hidden when hideFromToolbar is true.

Tool picker logic is centralized in isAgentToolBlock, which replaces the inline filter in tool-input.tsx (the old list explicitly excluded file and never included file_v5). Built-in tool classification in BUILT_IN_TOOL_TYPES now uses file_v5 instead of file, matching the block registry. Regression tests cover picker inclusion and built-in typing.

Reviewed by Cursor Bugbot for commit 09a0ddd. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR makes the current file_v5 block available in the Agent tool picker and classifies it as a built-in tool while continuing to exclude the hidden legacy File block.

  • Extracts the Agent-tool eligibility predicate into a reusable utility.
  • Adds file_v5 to the picker and built-in tool classification.
  • Adds regression tests for current and legacy File block handling.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The picker predicate preserves previous eligibility rules while intentionally adding file_v5; its operation-specific tools are registered and compatible with the existing Agent transformation path, and legacy stored File tools remain resolvable independently of picker grouping.

Important Files Changed
Filename Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/tool-input/utils.ts Introduces an Agent-tool eligibility predicate equivalent to the previous inline filter, with the intended addition of file_v5.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsx Uses the shared predicate to populate the Agent tool picker without changing existing tool eligibility beyond exposing the current File block.
apps/sim/blocks/utils.ts Replaces the hidden legacy File type with file_v5 in the picker-grouping set for built-in tools.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/tool-input/tool-input.test.ts Covers inclusion of file_v5, exclusion of legacy file, and rejection of unrelated visible core blocks.
apps/sim/blocks/utils.test.ts Verifies that built-in tool classification uses the current File block type rather than the legacy type.

Reviews (1): Last reviewed commit: "fix(agent): show files in tool picker" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@j15z