perf(server): stop calling our own API over HTTP during render, execution, and tool runs - #6660

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Aug 13, 2026 4:03pm

PR Summary

Medium Risk
Touches auth/credential resolution, workflow persistence, and provider execution paths—high-impact areas—but behavior is intended to match the removed HTTP routes with added tests; query fixes reduce silent UI bugs rather than changing server contracts.

Overview
In-process execution replaces round trips that re-authenticated work the caller already had: router and evaluator blocks call executeBlockProviderRequest instead of POST /api/providers; OAuth token logic lives in lib/oauth/token-resolution.ts with authorizeCredentialUseForAuth for route and executor; workflow state writes go through saveWorkflowNormalizedState (checkpoint revert and the state PUT route no longer HTTP-forward cookies).

SSR / prefetch seeds the workspace file list with a 300-file budget—above it nothing is seeded so the sidebar never treats a truncated list as complete—and file-folder prefetch parses through the route contract so hydrated shapes match client fetches.

React Query / hooks: table row optimistic updates walk infiniteRowsRoot only so cached search find entries don't break cell edits; CloudWatch selector keys include search; optimistic temp ids use generateId(); subscription and workspace-usage keys move to utils with shared invalidateWorkspaceUsage / scheduleUsageRefresh; knowledge doc deletes and uploads invalidate list docCount; schedule mutations refresh id-keyed reads; upgrade flows refresh broader billing state; useCloudStorageConfigured sets retryOnMount: true after transient errors.

^{Reviewed by Cursor Bugbot for commit aacc3e2. Configure here.}

Greptile Summary

This PR replaces several server-to-self HTTP requests with shared in-process execution paths while preserving authorization, validation, persistence, and notification behavior.

• Routes provider requests directly from router and evaluator handlers.
• Centralizes credential authorization and token resolution for API and executor callers.
• Extracts normalized workflow-state persistence for both checkpoint reverts and the state API.
• Corrects query keys, invalidation scopes, optimistic identifiers, file projections, and server-prefetch behavior.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

sequenceDiagram
  participant Caller as Server-side caller
  participant Shared as Shared in-process service
  participant Auth as Authorization
  participant DB as Database
  participant External as Provider / Realtime service
  Caller->>Shared: Execute provider, resolve token, or save workflow state
  Shared->>Auth: Verify access and permissions
  Auth-->>Shared: Authorized context
  Shared->>DB: Read or persist required state
  Shared->>External: Provider request or update notification
  Shared-->>Caller: Typed result without self-HTTP hop

_{Reviews (3): Last reviewed commit: "improvement(perf): drop a duplicate auth..." | Re-trigger Greptile}

@greptile

@cursor review

Ran a line-by-line adversarial audit of the full diff across six independent passes (executor/provider, OAuth credentials, workflow-state persistence, prefetch + file reads, React Query, request memoization). Every hunk was classified rather than assumed neutral. Follow-up commit addresses what it found:

Fixed a perf regression this PR had introduced. listWorkspaceFilesWithShares had been changed to read files then shares sequentially, so it could skip the share read on the rare over-budget workspace. That taxed every under-budget request — the common case, and the one the budget exists to make fast. Restored to Promise.all; the share read is discarded on overflow.

Closed a cache-seeding hole. The file read swallows errors and returns [], so a transient DB failure would have seeded an authoritative empty list — the user is told the workspace has no files. The seed now passes throwOnError: true so a failure reaches the catch and the client fetches instead.

Hardened the shared provider entry. It now omits the runtime context entirely when there is no trace registry, rather than passing one carrying undefined — executeProviderTool reads the latter as "provenance expected but missing" and fails a tool call closed with no error text. Unreachable today (these blocks declare no tools) but a silent failure the day one does. Also widened the stream guard's type check and added a completion log, since the removed route was the only thing logging these calls.

Test coverage for claims that had none:

• save-normalized-state.test.ts (new) pins the schema-equivalence claim — a checkpoint's deployedAt Date must parse identically to the JSON-serialized string it used to arrive as.
• A regression test for the row-cache prefix collision. Verified it fails against the pre-fix code and passes after.
• Evaluator now covers the two admission checks, mirroring the router.
• Boundary tests at exactly maxRows, and archived-visibility tests pinning the JS filter against the SQL predicate it replaced.

Two unrelated gaps found and fixed: useRedeployWorkflowSchedule never invalidated the id-keyed schedule reads (same class as the reactivate fix, one function below it), and a stale mock in the execution test.

Notable behavior changes now documented rather than presented as neutral: provider errors reaching the executor now carry their status code, so a router/evaluator model failure can surface as 402/503/429 where the HTTP hop previously flattened everything to 500 — this matches how the agent block has always behaved. Checkpoint revert returns 404 instead of 401 for an archived workflow. Both are refusals either way.

The highest-stakes question — whether cache() could memoize an authorization decision across a long-running request — was settled empirically against this Next version in both dev and production builds: route handlers get no cache scope, so the executor re-checks per block exactly as before.

Ran /simplify and /cleanup across the full diff (7 parallel passes: reuse, complexity, efficiency, hooks/React, comments, and an exhaustive fundamental-change scan).

The scan's verdict: no fundamental changes. Nothing persisted, no authorization decision, no audit/analytics/socket event, and no wire contract differs by mechanism. Every behavioral difference is either an artifact of a removed transport being restored, or a deliberate cache/staleness fix.

Two more round trips removed:

• Checkpoint revert authorized the workflow twice — once in the route, once inside the shared persistence helper. saveWorkflowNormalizedState now accepts an already-resolved authorization, cutting 2-3 sequential reads per revert without changing the decision or the route's 404-vs-denial distinction.
• resolveCredentialToken awaited resolveOAuthAccountId and then authorizeCredentialUseForAuth, though neither consumes the other and both branches authorize with identical arguments. Now one Promise.all, on the hottest new path (every credentialed tool call in every run).

Dead code removed: the WorkflowLockedError catch in the PUT state route (now unreachable — the lock comes back as a failure result), an extraMetadata parameter with no callers, an unreachable ?? credentialId fallback, a needless schema export, and three conditional spreads that JSON.stringify already handled.

Comments trimmed ~50%. Speculative "what a future change would need" paragraphs deleted; multi-paragraph justifications cut to one sentence; the cache() boilerplate that appeared in four files reduced to one canonical statement. Six load-bearing comments were kept deliberately — each prevents a plausible edit that would reintroduce a bug: why executionContext is withheld, why the runtime context is omitted rather than passed as undefined, why the file seed is all-or-nothing, why archived visibility is filtered in JS, why the memoized row is immutable, and why infiniteRowsRoot exists.

Reconsidered and kept two changes I had been about to neutralize. Provider errors now carrying status codes, and revert returning 404 instead of 401 for an archived workflow, are unintentional in origin but correct in outcome — the old values were artifacts, not designs. The agent block has always propagated provider statuses; 401 means unauthenticated and the user is authenticated; and the platform's own authz layer already returns 404 for an archived workflow. Preserving those would have been preserving the bug.

One further difference the scan surfaced, same category: an AbortError from a provider now propagates instead of being flattened, so isRetryableBlockError correctly declines to retry an aborted call — again matching the agent block.

Hooks/React pass came back clean: no new effects, state, memos, or callbacks, and no performance-idiom violations. type-check, biome, all four audit gates, and 1,412 tests pass.

@greptile

@cursor review