feat(windchill): add document webhook triggers - #6637
feat(windchill): add document webhook triggers#6637BillLeoutsakosvl346 wants to merge 10 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview The Windchill block now supports triggers ( A new Docs and Reviewed by Cursor Bugbot for commit c25592c. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThe PR adds four provider-managed Windchill document webhook triggers and wires their configuration, subscription lifecycle, registry metadata, tests, and documentation into Sim.
Confidence Score: 4/5The PR appears safe to merge from a functional perspective, with only non-blocking repository-convention cleanup needed. The Windchill subscription and delivery paths retain the existing request security controls, while the accepted findings are limited to import paths, filenames, and constant typing conventions. Files Needing Attention: apps/sim/triggers/windchill/index.ts and apps/sim/triggers/windchill/utils.ts
|
| Filename | Overview |
|---|---|
| apps/sim/lib/webhooks/providers/windchill.ts | Implements creation and cleanup of scoped Windchill EventMgmt subscriptions using existing authenticated and SSRF-protected request helpers. |
| apps/sim/triggers/windchill/utils.ts | Defines shared trigger fields, event mapping, validation, and setup instructions; its constants omit required const assertions. |
| apps/sim/blocks/blocks/windchill.ts | Enables Windchill triggers on the block and merges all four trigger configurations into its editor schema. |
| apps/sim/triggers/windchill/index.ts | Exposes the four trigger definitions through a barrel but uses relative paths contrary to repository rules. |
| apps/sim/lib/webhooks/providers/windchill.test.ts | Covers scope-specific request bodies, lifecycle filtering, validation, cleanup behavior, raw payload handling, and registry alignment. |
| apps/docs/content/docs/en/integrations/windchill.mdx | Documents configuration fields for all four new Windchill triggers. |
Sequence Diagram
sequenceDiagram
participant User
participant Sim as Sim Deployment
participant WRS as Windchill EventMgmt
participant Hook as Sim Webhook Ingress
participant Exec as Workflow Executor
User->>Sim: Configure and deploy Windchill trigger
Sim->>WRS: Create EventSubscription
WRS-->>Sim: Subscription ID
WRS->>Hook: POST raw document event
Hook->>Exec: Enqueue workflow execution
User->>Sim: Undeploy or replace trigger
Sim->>WRS: Delete EventSubscription
Reviews (1): Last reviewed commit: "docs(windchill): clarify trigger authent..." | Re-trigger Greptile
79a871a to
77cec66
Compare
Summary
Validation
git diff --checkStack
This PR is intentionally based on
plan-windchill-integration.