fix(workflow): allow dual-mode blocks inside loop/parallel subflows - #6633
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview In Reviewed by Cursor Bugbot for commit 508ebe3. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThis PR corrects subflow block insertion by distinguishing trigger capability from actual trigger mode.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified in the changed trigger-placement guard. Current insertion paths preserve explicit trigger mode when selecting a block as a trigger, while ordinary dual-mode selections are initialized without trigger mode as intended.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx | Narrows the subflow placement guard to actual trigger drops while preserving rejection for pure and explicitly enabled triggers. |
Reviews (1): Last reviewed commit: "fix(workflow): allow dual-mode blocks in..." | Re-trigger Greptile
Summary
triggers.enabled) as if the block were a trigger; it now only rejects blocks that will actually be triggers — pure trigger blocks (category === 'triggers') and explicit trigger-mode drops (enableTriggerMode)TriggerUtils.isTriggerBlockchecks the actualtriggerModestate)Type of Change
Testing
Traced the full picker →
add-block-from-toolbar→handleToolbarDroppath; type-check, lint, and the full audit suite pass. Pure trigger blocks and trigger-mode drags are still rejected from subflows.Checklist