fix(desktop): fix desktop prod ci - #6628
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThe PR fixes production desktop releases being cascade-skipped because GitHub Actions implicitly evaluates transitive dependencies.
Confidence Score: 5/5The PR appears safe to merge. The revised condition permits the intended production desktop release when its direct prerequisites succeed despite a skipped transitive dependency, while still rejecting failed, skipped, cancelled, or unsigned release paths.
|
| Filename | Overview |
|---|---|
| .github/workflows/ci.yml | Correctly scopes the desktop release gate to successful direct dependencies while preserving cancellation and signing checks. |
Reviews (1): Last reviewed commit: "Fix prod desktop release ci" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix desktop prod ci
Type of Change
Testing
manual
Checklist