Skip to content

fix(copilot): clamp the legacy int4 size when materializing a chat upload #6615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Aug 12, 2026
+64 −2
Merged

fix(copilot): clamp the legacy int4 size when materializing a chat upload #6615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions apps/sim/lib/copilot/tools/handlers/materialize-file.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,9 @@ const STORAGE_CONTEXT = {
customStorageLimitGB: null,
}

const POSTGRES_INT4_MAX = 2_147_483_647
const OVERSIZED_BYTES = 3 * 1024 * 1024 * 1024

const mothershipRow = {
id: 'file-1',
key: 'mothership/file-1',
Expand Down Expand Up @@ -339,6 +342,58 @@ describe('executeMaterializeFile - save storage transition', () => {
)
})

it('writes an int4-representable legacy size and the exact byte count above the int4 ceiling', async () => {
// A row above the int4 ceiling must not be written raw to `size`: Postgres
// raises 22003 and the save becomes unrecoverable.
mockHeadObject.mockResolvedValue({ size: OVERSIZED_BYTES, contentType: 'text/plain' })

const result = await executeMaterializeFile(
{ fileNames: ['report.txt'], operation: 'save' },
context
)

expect(result.success).toBe(true)
const [updateSet] = dbChainMockFns.set.mock.calls.at(-1) as [Record<string, unknown>]
expect(updateSet.size).toBe(POSTGRES_INT4_MAX)
expect(updateSet.sizeBytes).toBe(OVERSIZED_BYTES)
expect(mockCheckStorageQuotaForBillingContext).toHaveBeenCalledWith(
STORAGE_CONTEXT,
OVERSIZED_BYTES
)
expect(mockIncrementStorageUsageForBillingContextInTx).toHaveBeenCalledWith(
expect.anything(),
STORAGE_CONTEXT,
OVERSIZED_BYTES
)
})

it('falls back to the exact stored byte count, not the clamped legacy size', async () => {
// Without cloud storage a missing object does not short-circuit, so the row is
// the only size source — and its `size` is already clamped.
mockHeadObject.mockResolvedValue(null)
mockHasCloudStorage.mockReturnValue(false)
mockFindUpload.mockResolvedValue({
...mothershipRow,
size: POSTGRES_INT4_MAX,
sizeBytes: OVERSIZED_BYTES,
})

const result = await executeMaterializeFile(
{ fileNames: ['report.txt'], operation: 'save' },
context
)

expect(result.success).toBe(true)
const [updateSet] = dbChainMockFns.set.mock.calls.at(-1) as [Record<string, unknown>]
expect(updateSet.sizeBytes).toBe(OVERSIZED_BYTES)
expect(updateSet.size).toBe(POSTGRES_INT4_MAX)
expect(mockIncrementStorageUsageForBillingContextInTx).toHaveBeenCalledWith(
expect.anything(),
STORAGE_CONTEXT,
OVERSIZED_BYTES
)
})

it('materializes with an available root-level copy name', async () => {
mockFindUpload.mockResolvedValueOnce({
...mothershipRow,
Expand Down
11 changes: 9 additions & 2 deletions apps/sim/lib/copilot/tools/handlers/materialize-file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import {
} from '@/lib/uploads/contexts/workspace/workspace-file-manager'
import { getBoundWorkspaceFileSecretProvenance } from '@/lib/uploads/contexts/workspace/workspace-file-secret-provenance'
import { hasCloudStorage, headObject } from '@/lib/uploads/core/storage-service'
import { toLegacyWorkspaceFileSize } from '@/lib/uploads/shared/types'
import { isArchiveFileName } from '@/lib/uploads/utils/file-utils'
import { parseWorkflowJson } from '@/lib/workflows/operations/import-export'
import { saveWorkflowToNormalizedTables } from '@/lib/workflows/persistence/utils'
Expand Down Expand Up @@ -109,7 +110,12 @@ async function executeSave(
if (!head && hasCloudStorage()) {
return { success: false, error: `Upload object not found: "${fileName}".` }
}
const verifiedSize = head?.size ?? row.size
/**
* The true byte count can exceed the legacy int4 `size` column, so read the exact
* `sizeBytes` first and clamp back down for the legacy projection.
*/
const verifiedSize = head?.size ?? row.sizeBytes ?? row.size
const legacySize = toLegacyWorkspaceFileSize(verifiedSize)
const billingContext = await resolveStorageBillingContext(workspaceId)
const quotaCheck = await checkStorageQuotaForBillingContext(billingContext, verifiedSize)
if (!quotaCheck.allowed) {
Expand Down Expand Up @@ -145,7 +151,8 @@ async function executeSave(
messageId: null,
originalName: materializedName,
displayName: materializedName,
size: verifiedSize,
size: legacySize,
sizeBytes: verifiedSize,
})
.where(
and(
Expand Down
Loading