Skip to content

fix(knowledge): return pending status for new documents - #6597

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
fix/knowledge-single-document-processing-status
Aug 12, 2026
Merged

fix(knowledge): return pending status for new documents#6597
TheodoreSpeaks merged 1 commit into
stagingfrom
fix/knowledge-single-document-processing-status

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • return the persisted pending status for newly created knowledge documents
  • keep created-document types and route responses aligned with the response contract

Type of Change

  • Bug fix

Testing

  • 27 focused Vitest tests
  • Sim type-check
  • lint and repository audits

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 12, 2026 4:36am

Request Review

@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Narrow typing and return-value fix for document creation; no auth, billing, or processing pipeline behavior changes.

Overview
Ensures newly created knowledge documents return and persist processingStatus: 'pending', aligning the create response with the actual DB state.

createSingleDocument now includes processingStatus in both the inserted row and its return type. Downstream CreatedKnowledgeDocument typing makes the field required (still allowing later states on idempotent upload completion), and tests assert the create-document API returns pending.

Reviewed by Cursor Bugbot for commit 526ea5e. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR aligns newly created knowledge-document return types and API responses with the persisted pending processing state.

  • Adds processingStatus: 'pending' to the single-document creation result.
  • Widens idempotent lookup and orchestration types to represent later persisted processing states.
  • Updates focused service and migrated-route tests to verify the pending response contract.

Confidence Score: 5/5

The PR appears safe to merge with the creation result, persisted state, orchestration types, and route response consistently aligned.

Newly created documents return the pending state written to storage, while idempotent lookups retain later persisted lifecycle states without changing queue or retry behavior.

Important Files Changed

Filename Overview
apps/sim/lib/knowledge/documents/service.ts Returns the newly persisted pending status and correctly widens idempotent lookups to the complete persisted status union.
apps/sim/lib/knowledge/orchestration/documents.ts Aligns the created-document contract with new pending documents and existing documents returned in later lifecycle states.
apps/sim/app/api/knowledge/migrated-routes.test.ts Updates the creation fixture and verifies that the migrated route returns pending status.
apps/sim/lib/knowledge/documents/storage-billing.test.ts Verifies that single-document creation both persists and returns pending status.

Reviews (1): Last reviewed commit: "fix(knowledge): return pending status fo..." | Re-trigger Greptile

@TheodoreSpeaks
TheodoreSpeaks merged commit 326cb94 into staging Aug 12, 2026
30 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the fix/knowledge-single-document-processing-status branch August 12, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant