fix(tools): bind schema-enrichment reads to executor delegations by waleedlatif1 · Pull Request #6593 · simstudioai/sim

waleedlatif1 · 2026-08-12T04:18:45Z

Summary

tools/params.ts still called the deprecated buildAuthHeaders() (no subject) to read a child workflow, so /api/workflows/[id] — now on internalWorkflowReadAuth — rejected the legacy type: 'internal' token with a 401. The Agent block's workflow_executor inputMapping was left as an untyped { type: 'object' }, so the model guessed the child's field names and lazyCleanupInputMapping silently dropped the wrong keys.
tools/schema-enrichers.ts had the same break against /api/knowledge/[id]/tag-definitions. Worse blast radius: when an enricher returns null the parameter is dropped from the schema entirely, so knowledge_search / create_document / upsert_document lost tag filtering altogether.
Both now use buildExecutorDelegationHeaders, bound to the acting execution subject.
Extracted the executionId binding rule into executor/utils/delegation.ts — it was hand-rolled in three places. A child workflow binds on its own id, so forwarding the parent's executionId would assert a run that doesn't cover it.

Regression from #5273, which migrated the routes and the sibling call sites but missed these two. git diff origin/main -- apps/sim/tools/params.ts was empty. Audited every remaining buildAuthHeaders caller — the rest target routes still on legacy auth, so no other mismatch remains.

Type of Change

Bug fix

Testing

New tests assert the delegation binding and the resulting properties/required schema. Verified they fail against the pre-fix code (2 failures in params.test.ts, 3 in schema-enrichers.test.ts) — the existing inputMapping always included test sat on this path but asserted only type === 'object', which holds in the broken state, so it could not fail.
bunx vitest run tools/ providers/ executor/ — 5,981 passing.
Repo-wide lint:check and type-check (23/23 each), plus check:api-validation, monorepo-boundary and realtime-prune gates.
Not exercised against a live workspace: this path only runs server-side during a real agent run with a child workflow.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Two schema-enrichment callers still sent the deprecated legacy internal JWT to routes that moved onto delegation-only auth, so both 401'd and swallowed the failure: - tools/params.ts fetched a child workflow's input fields with an unsubjected buildAuthHeaders(), leaving the Agent block's workflow_executor inputMapping untyped so the model guessed the child's field names. - tools/schema-enrichers.ts fetched KB tag definitions the same way, which dropped the tags/tagFilters parameter from the knowledge tools entirely. Extract the executionId binding rule into executionScopeForTarget so the three enrichment call sites share one definition.

vercel · 2026-08-12T04:18:51Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Aug 12, 2026 4:20am

cursor · 2026-08-12T04:18:56Z

PR Summary

Medium Risk
Touches internal auth token binding for schema-enrichment API reads during agent runs. Incorrect executionId scoping could break enrichment or fail route authorization, though the change restores the intended delegation model with focused tests.

Overview
Restores LLM schema enrichment for child workflows and knowledge-base tags after those routes started rejecting legacy internal tokens.

fetchWorkflowInputFields and KB tag-definition reads now authenticate with buildExecutorDelegationHeaders bound to the acting subject, so workflow_executor inputMapping and KB tag filters populate again instead of silently degrading.

Extracts shared executionScopeForTarget so executionId is only forwarded when the target is the running workflow — child workflows bind on their own id. providers/utils adopts the same helper.

^{Reviewed by Cursor Bugbot for commit a939738. Configure here.}

Enrichment degrades silently by design, so the log line is the only signal a credential break leaves. Drain the body on the failure path too.

greptile-apps · 2026-08-12T04:21:31Z

Greptile Summary

The PR replaces legacy internal authentication on workflow and knowledge schema-enrichment reads with executor delegations bound to the acting subject. It also centralizes execution-scope selection and adds regression coverage for same-workflow, child-workflow, missing-context, and rejected-read behavior.

Adds executionScopeForTarget to include a run ID only when it belongs to the delegation’s target workflow.
Uses scoped delegation headers for child-workflow input schemas and knowledge-base tag schemas.
Adds tests covering delegation claims and resulting enriched schema properties.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
apps/sim/executor/utils/delegation.ts	Introduces a focused helper that prevents a parent run ID from being asserted against a child-workflow delegation.
apps/sim/providers/utils.ts	Reuses the centralized execution-scope rule when fetching workflow metadata.
apps/sim/tools/params.ts	Uses the acting execution subject for delegated workflow reads and enriches workflow-executor input mappings with child input fields.
apps/sim/tools/schema-enrichers.ts	Migrates knowledge tag-definition enrichment to workflow-scoped executor delegation while retaining graceful fallback behavior.
apps/sim/executor/utils/delegation.test.ts	Covers same-workflow, child-workflow, inactive-run, and missing-workflow delegation scopes.
apps/sim/tools/params.test.ts	Verifies delegation claims and workflow input schema enrichment, including missing-subject and authorization-failure fallbacks.
apps/sim/tools/schema-enrichers.test.ts	Verifies knowledge tag enrichment uses the acting subject and appropriate workflow execution binding.

Sequence Diagram

sequenceDiagram
  participant Exec as Workflow Executor
  participant Tool as Tool Schema Enricher
  participant Auth as Delegation Builder
  participant API as Internal API
  Exec->>Tool: Build schema with execution context
  Tool->>Auth: subjectUserId + target workflow
  alt Target is running workflow
    Tool->>Auth: Include executionId
  else Target is child workflow
    Tool->>Auth: Omit parent executionId
  end
  Auth-->>Tool: Scoped delegation headers
  Tool->>API: Read workflow or tag definitions
  API-->>Tool: Authorized enrichment data
  Tool-->>Exec: Enriched tool schema

_{Reviews (2): Last reviewed commit: "improvement(tools): surface tag-definiti..." | Re-trigger Greptile}

waleedlatif1 · 2026-08-12T04:22:16Z

@greptile

waleedlatif1 · 2026-08-12T04:22:17Z

@cursor review

waleedlatif1 · 2026-08-12T04:22:21Z

@greptile

waleedlatif1 · 2026-08-12T04:22:22Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit a939738. Configure here.}

improvement(tools): surface tag-definition read failures at error level

a939738

Enrichment degrades silently by design, so the log line is the only signal a credential break leaves. Drain the body on the failure path too.

vercel Bot temporarily deployed to Preview August 12, 2026 04:20 Inactive

waleedlatif1 merged commit a61cbf7 into staging Aug 12, 2026
22 checks passed

waleedlatif1 deleted the investigate/delegation-headers branch August 12, 2026 04:22

cursor Bot reviewed Aug 12, 2026

View reviewed changes

This was referenced Aug 12, 2026

test(table): pin the executor auth pairing on the table read route #6603

Merged

v0.8.0: desktop app, workflow UI, v2 endpoints #6606

Merged

Navigation Menu

Uh oh!

fix(tools): bind schema-enrichment reads to executor delegations - #6593

fix(tools): bind schema-enrichment reads to executor delegations#6593
waleedlatif1 merged 2 commits into
stagingfrom
investigate/delegation-headers

waleedlatif1 commented Aug 12, 2026

Uh oh!

vercel Bot commented Aug 12, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Aug 12, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Aug 12, 2026 •

edited

Loading

Important Files Changed

Sequence Diagram

Uh oh!

waleedlatif1 commented Aug 12, 2026

Uh oh!

waleedlatif1 commented Aug 12, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Aug 12, 2026

Uh oh!

waleedlatif1 commented Aug 12, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

waleedlatif1 commented Aug 12, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-apps Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

waleedlatif1 commented Aug 12, 2026

Uh oh!

waleedlatif1 commented Aug 12, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Aug 12, 2026

Uh oh!

waleedlatif1 commented Aug 12, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Aug 12, 2026 •

edited

Loading

cursor Bot commented Aug 12, 2026 •

edited

Loading

greptile-apps Bot commented Aug 12, 2026 •

edited

Loading