improvement(desktop, executions): fix desktop update script and throw error when thinking enabled on stream false - #6578
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR tightens workflow-execution validation for agent-event options and improves desktop update-channel resolution behind reverse proxies.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking recommendation to avoid trusting forwarded hostnames unless the deployment guarantees they are sanitized by a trusted proxy. The workflow validation and generated contract are coordinated, while desktop channel selection can silently skip origin updates in deployments that preserve or supply an incorrect forwarded hostname. Files Needing Attention: apps/sim/app/api/desktop/update/latest-mac.yml/route.ts
|
| Filename | Overview |
|---|---|
| apps/sim/app/api/desktop/update/latest-mac.yml/route.ts | Adds forwarded-host-based update-channel selection, but assumes the first forwarded hostname is trustworthy. |
| apps/sim/app/api/desktop/update/latest-mac.yml/route.test.ts | Adds coverage for forwarded public hostnames and Host-header fallback across release channels. |
| apps/sim/app/api/v2/workflows/[id]/execute/route.ts | Rejects agent-event options outside streaming mode before validating the stream protocol header. |
| apps/sim/lib/api/contracts/v2/workflows.ts | Centralizes documentation of the new stream requirement in the shared execution constraints. |
| apps/sim/lib/api/contracts/v2/openapi/workflows.ts | Reuses the shared execution-constraint text in the workflow operation description. |
| apps/docs/openapi-v2-workflows.json | Regenerates the public OpenAPI document with the new stream-only option constraint. |
Reviews (1): Last reviewed commit: "fix include tool calls error" | Re-trigger Greptile
Summary
Fix desktop update script and throw error when thinking enabled on stream false
Type of Change
Testing
Manual
Checklist