Skip to content

fix(mship, desktop): fix bugs - #6572

Merged
Sg312 merged 3 commits into
stagingfrom
improvement-desktop
Aug 12, 2026
Merged

fix(mship, desktop): fix bugs#6572
Sg312 merged 3 commits into
stagingfrom
improvement-desktop

Conversation

@Sg312

@Sg312 Sg312 commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

Fix mship and desktop app bugs
Companion: https://github.com/simstudioai/mothership/pull/433

Type of Change

  • Bug fix

Testing

Manual

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 12, 2026 12:12am

Request Review

@greptile-apps

greptile-apps Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR revises desktop release streams and update handling, fixes Copilot abort ordering, and adjusts Mothership interaction rendering. It also removes desktop folder-management controls while persistent filesystem grants remain active.

  • Renames prerelease streams from alpha/beta to dev/staging while preserving legacy compatibility.
  • Adds origin-aware desktop update feeds, stricter manifest validation, timeouts, and one-action download/install behavior.
  • Writes Copilot’s explicit abort marker before terminating the local stream.
  • Collapses superseded credential prompts and streamlines single-select question interaction.
  • Removes the Desktop settings interface for local-folder grants.

Confidence Score: 3/5

The PR should not merge until users retain an in-app way to inspect and revoke persistent local-folder access.

Existing filesystem grants survive restarts and remain available to Copilot tools, while this change removes the sole settings UI that listed and revoked them; the new route test also violates the repository’s absolute-import convention.

Files Needing Attention: apps/sim/app/workspace/[workspaceId]/settings/components/desktop/desktop.tsx; apps/sim/app/api/desktop/update/latest-mac.yml/route.test.ts

Security Review

The Desktop settings change removes the only in-app revocation path for persistent local-folder grants. Existing grants are restored at startup and remain usable by Copilot filesystem tools, leaving users unable to inspect or revoke that access from the application.

Important Files Changed
Filename Overview
apps/desktop/src/main/updater.ts Reworks update-channel resolution, feed probing, candidate validation, timeouts, and explicit download-to-install behavior; no confirmed blocking updater defect remains.
apps/sim/app/api/desktop/update/latest-mac.yml/route.ts Selects update streams from the request hostname, distinguishes authoritative no-release responses, and validates manifest versions against release tags.
apps/sim/app/api/copilot/chat/abort/route.ts Moves the bounded Go abort-marker request before local SSE teardown to prevent deliberate stops from being misclassified.
apps/sim/app/workspace/[workspaceId]/settings/components/desktop/desktop.tsx Simplifies desktop settings but removes the only UI for inspecting and revoking persistent local filesystem grants.
apps/sim/app/api/desktop/update/latest-mac.yml/route.test.ts Adds update-feed coverage but introduces a relative import contrary to the apps/sim absolute-import rule.
apps/sim/app/workspace/[workspaceId]/home/components/mothership-chat/mothership-chat.tsx Marks superseded credential interactions as abandoned so historical prompts render as recaps instead of active forms.

Flowchart

 
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Shell[Desktop shell] --> Feed[Environment update feed]
  Feed --> Release[Matching dev, staging, or stable release]
  Release --> Updater[Desktop updater]
  Updater --> Download[Download update]
  Download --> Install[Install and relaunch]
  User[User grants local folder] --> Store[Persistent encrypted grant store]
  Store --> Restore[Restore grant at startup]
  Restore --> Tools[Copilot filesystem tools]
  Settings[Desktop settings] -. no revoke control .-> Store
Loading

Reviews (1): Last reviewed commit: "fix bugs" | Re-trigger Greptile

greptile-apps[bot]
greptile-apps Bot reviewed Aug 11, 2026
View reviewed changes
Comment thread apps/sim/app/workspace/[workspaceId]/settings/components/desktop/desktop.tsx
Comment thread apps/sim/app/api/desktop/update/latest-mac.yml/route.test.ts Outdated
@github-actions github-actions Bot added the requires-mothership-merge Has a companion PR on the mothership/copilot side — merge in lockstep label Aug 11, 2026
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

⚠️ Cross-repo companion check

One or more companion PRs aren't merged into staging yet. Merging this without them will leave copilot and sim out of sync — merge them in lockstep.

@Sg312
Sg312 merged commit cb28090 into staging Aug 12, 2026
28 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement-desktop branch August 12, 2026 00:18
@waleedlatif1 waleedlatif1 mentioned this pull request Aug 12, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees

No one assigned

Labels

requires-mothership-merge Has a companion PR on the mothership/copilot side — merge in lockstep

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Sg312