fix(enrichment): wait for valid work email inputs - #6531
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Adds shared readiness checks used by scheduling, workers, and the grid. Work-email’s PDL provider now requires LinkedIn or name+company. Incomplete rows show Waiting; in-flight reruns still keep the previous value until replacement. Also tracks Reviewed by Cursor Bugbot for commit efbcebf. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThe PR prevents work-email enrichments from running until a provider can form a valid request and preserves manual-run provenance so readiness states remain accurate across dispatch, resume, persistence, and SSE updates.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/enrichments/readiness.ts | Centralizes required-input and provider-request readiness, including actionable fallback labels when normalized values are rejected. |
| apps/sim/enrichments/work-email/work-email.ts | Tightens PDL request construction to LinkedIn or name-plus-company inputs and aligns it with readiness evaluation. |
| apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/data-row.tsx | Computes per-row readiness labels while requiring authoritative manual-run provenance for autoRun:false cells. |
| apps/sim/background/workflow-column-execution.ts | Gates enrichment execution on provider readiness and carries manual-run provenance through cascade state writes. |
| apps/sim/background/resume-execution.ts | Preserves the originating cell’s manual-run provenance across paused workflow resumes and subsequent cascade continuation. |
| apps/sim/lib/table/rows/service.ts | Applies stale enrichment invalidation and downstream cancellation consistently to upserts and filtered updates. |
| apps/sim/lib/table/rows/executions.ts | Persists and projects manual-run provenance in execution JSON metadata without loading full enrichment details into grid reads. |
| apps/sim/hooks/queries/tables.ts | Mirrors server readiness and invalidation behavior in optimistic row and manual-run cache updates. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Mapped row inputs change] --> B[Evaluate provider readiness]
B -->|No valid request| C[Clear stale enrichment state]
C --> D[Show Waiting with actionable inputs]
B -->|Valid request| E[Dispatch enrichment]
E --> F[Persist manual-run provenance]
F --> G[Queued / Running / Resumed]
G --> H[Terminal result and SSE update]
Reviews (18): Last reviewed commit: "fix(enrichment): cancel upsert dependent..." | Re-trigger Greptile
# Conflicts: # apps/sim/background/workflow-column-execution.ts
|
@cursor review |
|
@cursor review |
|
@cursor review |
|
@cursor review |
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 25c1978. Configure here.
|
bugbot run |
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f4864e0. Configure here.
|
bugbot run |
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit efbcebf. Configure here.
Summary
Type of Change
Testing
Checklist