fix(comparisons): make sandbox and session-policy rows binary - #6524
fix(comparisons): make sandbox and session-policy rows binary#6524waleedlatif1 wants to merge 1 commit into
Conversation
A comparison row answers a binary question, so the three-state Partial/Not-publicly-documented framing was wrong. Re-derive both rows against one rule: a capability counts as Yes when any documented, vendor-supported path exists, including self-hosted-only, package-layer only, tier-gated, and configured in the vendor's own identity layer. Undocumented and vendor-fixed become No. Every constraint moves into the value's later sentences and detail rather than the verdict.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Yes when any documented vendor-supported path exists (self-hosted-only, package-layer-only, tier-gated, env-var-driven, or Microsoft Entra/Power Platform identity layers still count). No when the runtime or session is fixed with no documented admin control, nothing is documented, or only a third-party IdP sets timeouts. Nuance (plan gates, deployment mode, limits) stays in Sim’s sandbox row wording is tightened (Max/Enterprise gating upfront); session policy Reviewed by Cursor Bugbot for commit 0783ad9. Configure here. |
Greptile SummaryThe PR converts configurable-sandbox and session-policy comparison entries to strict binary Yes/No verdicts while retaining deployment, tier, and runtime constraints in their explanatory copy.
Confidence Score: 4/5The Gumloop session-policy verdict should be corrected before merging because it publishes a false negative under the PR’s own binary classification rule. Gumloop is assigned a negative verdict even though its cited first-party documentation states that configurable session timeouts are supported and sibling entries accept the same level of evidence. Files Needing Attention: apps/sim/lib/compare/data/competitors/gumloop.ts
|
| Filename | Overview |
|---|---|
| apps/sim/lib/compare/data/competitors/gumloop.ts | Reclassifies session policy as No despite quoting Gumloop’s vendor documentation that configurable session timeouts are supported. |
| apps/sim/lib/compare/data/competitors/power-automate.ts | Reframes desktop dependency-loading support as Yes while preserving the fixed-cloud-runtime distinction. |
| apps/sim/lib/compare/data/competitors/crewai.ts | Reframes AMP package declarations as a qualifying Yes and retains the absence of a first-party sandbox. |
| apps/sim/lib/compare/data/sim.ts | Moves Sim’s plan gating into the leading sandbox and session-policy summaries without changing capabilities. |
Reviews (1): Last reviewed commit: "fix(comparisons): make sandbox and sessi..." | Re-trigger Greptile
| value: | ||
| 'Not publicly documented: no admin-configurable session lifetime or idle timeout appears in Gumloop\'s public documentation. The only primary-source statement is a single bullet on the Enterprise SSO page listing "Session Management: Configurable session timeouts and secure token handling." No admin setting name, configuration steps, default session lifetime, idle-timeout value, or absolute-cap value is published anywhere in Gumloop\'s docs, security page, or trust center.', | ||
| 'No: no admin-configurable session lifetime or idle timeout appears in Gumloop\'s public documentation. The only primary-source statement is a single bullet on the Enterprise SSO page listing "Session Management: Configurable session timeouts and secure token handling." No admin setting name, configuration steps, default session lifetime, idle-timeout value, or absolute-cap value is published anywhere in Gumloop\'s docs, security page, or trust center, so a buyer has no documented control to rely on.', | ||
| detail: |
There was a problem hiding this comment.
When the comparison renders Gumloop’s session policy, the changed No: prefix classifies it as unsupported even though Gumloop’s cited Enterprise SSO documentation states that configurable session timeouts are supported, causing a false negative in the table and structured comparison data.
Summary
codeSandboxRuntimeandsessionPolicyas strict binaryYes:/No:across Sim and all 20 competitors. A comparison row answers a binary question; the three-statePartial:/Not publicly documented:framing made every row read as a hedgedetail, which ship in full to crawlers and screen readers and are reachable via the row's source linkThe rule
A capability is Yes when any documented, vendor-supported path exists. Self-hosted-only, package-layer-only, tier-gated, env-var-configured, and configured in the vendor's own identity layer (Entra/Power Platform for Microsoft) all count as Yes.
No when the environment/session is vendor-fixed with no documented configuration on any deployment mode, when nothing is documented anywhere, or when the only path is a third-party IdP the vendor doesn't own.
Note this deliberately resolves ambiguity toward the competitor — every former
Partial:became aYes:, not aNo:.Result
Type of Change
Testing
Type-check and biome clean (the only
tscerrors in my worktree are stale-symlink@sim/emcnicon exports from #6523, unrelated to this diff — zero errors inlib/compare). Diff is +52/-50 across 19 files: a surgical verdict rewrite. An audit pass diffed each file against git to confirm no version number, limit, env-var name, or plan gate was dropped in the reframing.Checklist