-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat(search): page-aware cmd+k palette with ask-Sim mode #6518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
04147f7
b840a3a
cd23af8
ed4ea7c
d078e82
81716ff
45357cb
3e67769
fc881bf
a4625ab
1ce85ca
1091783
00dceb4
ecb6ade
9139781
160d500
16a6787
c1bd985
852f700
08128f1
a77ce2a
62971be
5a8ac0d
c4b2728
b0ecf22
9b82ef4
693e245
b39bb97
61a2559
9ad2d36
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,7 @@ import { | |
| } from '@/app/workspace/[workspaceId]/components/folders' | ||
| import { PresenceAvatars } from '@/app/workspace/[workspaceId]/components/presence/presence-avatars' | ||
| import { LogDetails } from '@/app/workspace/[workspaceId]/logs/components' | ||
| import { useRegisterGlobalCommands } from '@/app/workspace/[workspaceId]/providers/global-commands-provider' | ||
| import { useUserPermissionsContext } from '@/app/workspace/[workspaceId]/providers/workspace-permissions-provider' | ||
| import { ImportCsvDialog } from '@/app/workspace/[workspaceId]/tables/components/import-csv-dialog' | ||
| import { ImportProgressMenu } from '@/app/workspace/[workspaceId]/tables/components/import-progress-menu' | ||
|
|
@@ -1068,6 +1069,34 @@ export function Table({ | |
| } | ||
| }, [tableData, workspaceId]) | ||
|
|
||
| useRegisterGlobalCommands(() => [ | ||
| { | ||
| id: 'table-new-column', | ||
| handler: () => { | ||
| if (!userPermissions.canEdit) return | ||
| if (tableDataRef.current?.locks.schemaLocked) { | ||
| showBlockedToast('add-column') | ||
| return | ||
| } | ||
| handleAddColumnOfType('string') | ||
| }, | ||
| }, | ||
| { | ||
| id: 'table-export-csv', | ||
| handler: () => { | ||
| if (!tableDataRef.current?.rowCount) return | ||
| void handleExportCsv() | ||
| }, | ||
| }, | ||
| { | ||
| id: 'table-import-csv', | ||
| handler: () => { | ||
| if (!userPermissions.canEdit || tableDataRef.current?.locks.insertLocked) return | ||
| onRequestImportCsv() | ||
| }, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Silent locked CSV importMedium Severity
Additional Locations (1)Reviewed by Cursor Bugbot for commit b39bb97. Configure here. |
||
| }, | ||
| ]) | ||
|
|
||
| const columnOptions = useMemo<ColumnOption[]>( | ||
| () => | ||
| columns.map((col) => ({ | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silent empty CSV export
Low Severity
table-export-csvis always offered on table detail, but the handler no-ops whenrowCountis 0. The header Export control is disabled for empty tables, so the palette path gives no indication why nothing happened—the same class of silent failure the deploy action was later fixed to toast for.Additional Locations (1)
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx#L369-L378Reviewed by Cursor Bugbot for commit b39bb97. Configure here.