Skip to content

fix(knowledge): pluralize the module header and root breadcrumb #6516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j15z merged 1 commit into from
Aug 11, 2026
Merged

fix(knowledge): pluralize the module header and root breadcrumb #6516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ export function Document({
() =>
combinedError
? [
{ label: 'Knowledge Base', icon: Database, onClick: handleNavToKB },
{ label: 'Knowledge bases', icon: Database, onClick: handleNavToKB },
{
label: knowledgeBaseCrumbLabel,
icon: Database,
Expand All @@ -519,7 +519,7 @@ export function Document({
{ label: 'Error' },
]
: [
{ label: 'Knowledge Base', icon: Database, onClick: handleNavToKB },
{ label: 'Knowledge bases', icon: Database, onClick: handleNavToKB },
{
label: knowledgeBaseCrumbLabel,
icon: Database,
Expand Down Expand Up @@ -989,7 +989,7 @@ export function Document({

const editorBreadcrumbBase = useMemo<BreadcrumbItem[]>(
() => [
{ label: 'Knowledge Base', icon: Database, onClick: handleNavToKB },
{ label: 'Knowledge bases', icon: Database, onClick: handleNavToKB },
{
label: knowledgeBaseCrumbLabel,
icon: Database,
Expand Down Expand Up @@ -1022,7 +1022,7 @@ export function Document({

const loadingBreadcrumbs = useMemo<BreadcrumbItem[]>(
() => [
{ label: 'Knowledge Base', icon: Database, onClick: handleNavToKB },
{ label: 'Knowledge bases', icon: Database, onClick: handleNavToKB },
{
label: knowledgeBaseCrumbLabel,
icon: Database,
Expand Down
2 changes: 1 addition & 1 deletion apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/loading.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const COLUMNS = [
const ACTIONS: ChromeActionSpec[] = [{ text: 'New chunk', icon: Plus, variant: 'primary' }]

const BREADCRUMBS: BreadcrumbItem[] = [
{ label: 'Knowledge Base', icon: Database, onClick: noop },
{ label: 'Knowledge bases', icon: Database, onClick: noop },
{ label: '…', icon: Database },
{ label: '…', terminal: true },
]
Expand Down
6 changes: 3 additions & 3 deletions apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ export function KnowledgeBase({
/**
* Breadcrumb leaf label. Falls back to the canonical '…' placeholder while
* the name loads (mirroring loading.tsx) instead of duplicating the root
* "Knowledge Base" crumb.
* "Knowledge bases" crumb.
*/
const knowledgeBaseCrumbLabel = knowledgeBase?.name || passedKnowledgeBaseName || '…'
const error = knowledgeBaseError || documentsError
Expand Down Expand Up @@ -872,7 +872,7 @@ export function KnowledgeBase({

const breadcrumbs: BreadcrumbItem[] = [
{
label: 'Knowledge Base',
label: 'Knowledge bases',
icon: Database,
onClick: () => router.push(`/workspace/${workspaceId}/knowledge`),
},
Expand Down Expand Up @@ -1182,7 +1182,7 @@ export function KnowledgeBase({
<Resource onContextMenu={handleEmptyContextMenu}>
<Resource.Header
icon={Database}
title='Knowledge Base'
title='Knowledge bases'
breadcrumbs={breadcrumbs}
actions={[
...headerActions,
Expand Down
2 changes: 1 addition & 1 deletion apps/sim/app/workspace/[workspaceId]/knowledge/[id]/loading.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const ACTIONS: ChromeActionSpec[] = [
]

const BREADCRUMBS: BreadcrumbItem[] = [
{ label: 'Knowledge Base', icon: Database, onClick: noop },
{ label: 'Knowledge bases', icon: Database, onClick: noop },
{ label: '…', icon: Database, terminal: true },
]

Expand Down
2 changes: 1 addition & 1 deletion apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ const CONTENT_FILTER_OPTIONS: ChipDropdownOption[] = [

const FILTER_SECTION_LABEL_CLASS = 'text-[var(--text-muted)] text-small'

const ROOT_BREADCRUMB_LABEL = 'Knowledge Base'
const ROOT_BREADCRUMB_LABEL = 'Knowledge bases'
const FOLDER_RESOURCE_TYPE = 'knowledge_base' as const

function connectorCell(connectorTypes?: string[]): ResourceCell {
Expand Down
2 changes: 1 addition & 1 deletion apps/sim/app/workspace/[workspaceId]/knowledge/loading.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default function KnowledgeLoading() {
return (
<ResourceChromeFallback
icon={Database}
title='Knowledge Base'
title='Knowledge bases'
columns={COLUMNS}
actions={ACTIONS}
searchPlaceholder='Search knowledge bases...'
Expand Down
2 changes: 1 addition & 1 deletion apps/sim/app/workspace/[workspaceId]/knowledge/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import KnowledgeLoading from '@/app/workspace/[workspaceId]/knowledge/loading'
import { prefetchKnowledgeBases } from '@/app/workspace/[workspaceId]/knowledge/prefetch'

export const metadata: Metadata = {
title: 'Knowledge Base',
title: 'Knowledge bases',
}

/**
Expand Down
Loading