fix(folders): show the folder trail in table and knowledge base headers by waleedlatif1 · Pull Request #6515 · simstudioai/sim

waleedlatif1 · 2026-08-11T01:08:38Z

Summary

A table or knowledge base opened from inside a folder rendered Tables / name, dropping every folder between it and the root, while a file's header showed the full Files / docs / name path. The detail pages never read the resource's own folderId, so the trail could not include it.
Rather than patch the two headers, all six foldered surfaces (Files, Tables, Knowledge — list and detail) now build their trail from one shared builder:
- folderAncestorChain(folderId, lookup) in lib/folders/tree.ts is the single upward walk. Both getFolderPath variants delegate to it. The two lock predicates deliberately keep their inline walks — they short-circuit at the first locked ancestor on a per-row render path.
- folderBreadcrumbItems takes a trailing slot for detail pages, as a discriminated union so an open-folder rename can't be passed alongside it and silently dropped.
- useFolderAncestors owns the folder tree plus the foldersResolved staleness rule; useFolderNavigation delegates to it.
- FOLDERED_RESOURCE_HEADERS owns each resource's root label, root icon, and list path, which seven sites previously restated.
Files' list trail moved off splitting the materialized path string, which couldn't tell two same-named siblings apart, onto the shared parentId walk.
Also fixes the Files loading trail, whose folder crumbs used the nuqs setter while rendering on the file detail route — appending ?folderId= to the open file's own URL instead of navigating to the list.

Type of Change

Bug fix

Testing

tsc --noEmit, bun run lint:check, and bun run check:react-query / check:api-validation / check:client-boundary all clean. 2902 tests across 249 files pass, including new coverage for the chain walk and the detail-page trail; I verified those tests fail against a deliberately broken implementation.

Not yet verified in a browser — the dev server won't start from a git worktree (Turbopack resolves the outer repo as root). The visual change is the folder segments now appearing in table/KB headers, so it's worth a look on the preview before merge.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-08-11T01:08:45Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Aug 11, 2026 1:31am

cursor · 2026-08-11T01:08:48Z

PR Summary

Medium Risk
Cross-resource header and navigation changes with shared folder-tree correctness rules (foldersResolved, partial chains); no auth or data-model changes, but regressions would show wrong paths or broken crumb navigation.

Overview
Foldered Files, Tables, and Knowledge list and detail headers now build the same trail from one path: walk parentId via folderAncestorChain, validate completeness with breadcrumbFolderChain, and assemble crumbs with folderBreadcrumbItems (list mode keeps rename/menu on the open folder; detail mode uses trailing crumbs so every folder segment navigates).

Table and knowledge base detail pages were missing intermediate folders because they never used the resource’s folderId; they now load the chain through useFolderAncestors. List navigation still uses useFolderNavigation, which delegates ancestry to that hook and exposes ancestors instead of duplicating tree fetch logic.

FOLDERED_RESOURCE_HEADERS and folderedResourceListHref / folderListHref centralize root labels, icons, and list URLs (including Recently deleted folder links). Files list breadcrumbs no longer split a materialized path string (ambiguous siblings); loading/detail folder crumbs navigate to the files list route instead of mutating the open file URL with nuqs.

^{Reviewed by Cursor Bugbot for commit 1df52e0. Configure here.}

greptile-apps · 2026-08-11T01:11:28Z

Greptile Summary

This PR unifies breadcrumb construction across foldered resource surfaces so list and detail headers show complete folder ancestry.

Adds shared folder-chain, breadcrumb, navigation, and resource-header helpers.
Updates Files, Tables, and Knowledge surfaces to use resource folderId ancestry.
Routes document breadcrumb navigation through the existing unsaved-edit guard.
Adds coverage for ancestor traversal, incomplete trees, cycles, and detail-page trails.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/components/folders/folder-breadcrumbs.ts	Introduces shared folder-chain validation and list/detail breadcrumb construction.
apps/sim/app/workspace/[workspaceId]/components/folders/use-folder-ancestors.ts	Centralizes folder-tree fetching, resolution state, and ancestor derivation.
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx	Adds full knowledge-base folder ancestry and guards route-leaving breadcrumbs while the chunk editor is open.
apps/sim/app/workspace/[workspaceId]/files/files.tsx	Replaces path-string breadcrumb reconstruction with parent-ID traversal and correct list-route navigation.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx	Adds the table's folder ancestry to its detail-page header.
apps/sim/lib/folders/tree.ts	Provides the shared cycle-safe ancestor walk used by foldered surfaces.

_{Reviews (4): Last reviewed commit: "chore(folders): tighten the shared bread..." | Re-trigger Greptile}

waleedlatif1 · 2026-08-11T01:14:37Z

@greptile

waleedlatif1 · 2026-08-11T01:14:41Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit e54c733. Configure here.}

A table or knowledge base opened from inside a folder rendered `Tables / name`, dropping every folder between it and the root — while a file's header showed the full `Files / docs / name` path. The detail pages never read the resource's own `folderId`, so the trail could not include it. Converge all six foldered surfaces on one builder instead of fixing the two headers in place: - `folderAncestorChain(folderId, lookup)` in `lib/folders/tree.ts` is now the single upward walk. Both `getFolderPath` variants delegate to it; the two lock predicates deliberately keep their inline walks, which short-circuit at the first locked ancestor on a per-row render path. - `folderBreadcrumbItems` takes a `trailing` slot for detail pages, as a discriminated union so an open-folder rename cannot be passed alongside it and silently dropped. - `useFolderAncestors` owns the tree plus the `foldersResolved` staleness rule; `useFolderNavigation` now delegates to it. - `FOLDERED_RESOURCE_HEADERS` owns each resource's root label, root icon, and list path, which seven sites previously restated. Files' list trail moved off splitting the materialized `path` string, which could not tell two same-named siblings apart, onto the shared parentId walk. Also fixes the Files loading trail, whose folder crumbs used the nuqs setter while rendering on the file detail route — appending `?folderId=` to the open file's own URL instead of navigating to the list.

…saved chunk

…stry

waleedlatif1 · 2026-08-11T01:24:17Z

@greptile

waleedlatif1 · 2026-08-11T01:24:21Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit e409ad9. Configure here.}

…estry type

waleedlatif1 · 2026-08-11T01:31:17Z

@greptile

waleedlatif1 · 2026-08-11T01:31:20Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 1df52e0. Configure here.}

greptile-apps Bot reviewed Aug 11, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx

waleedlatif1 force-pushed the folder-toolbar-header branch from 6379114 to e54c733 Compare August 11, 2026 01:14

vercel Bot temporarily deployed to Preview August 11, 2026 01:14 Inactive

cursor Bot reviewed Aug 11, 2026

View reviewed changes

waleedlatif1 added 3 commits August 10, 2026 18:20

fix(knowledge): confirm before a breadcrumb navigates away from an un…

010608d

…saved chunk

fix(knowledge): source the pluralized root label from the folder regi…

e409ad9

…stry

waleedlatif1 force-pushed the folder-toolbar-header branch from e54c733 to e409ad9 Compare August 11, 2026 01:23

vercel Bot temporarily deployed to Preview August 11, 2026 01:24 Inactive

cursor Bot reviewed Aug 11, 2026

View reviewed changes

chore(folders): tighten the shared breadcrumb docs and dedupe the anc…

1df52e0

…estry type

vercel Bot temporarily deployed to Preview August 11, 2026 01:31 Inactive

cursor Bot reviewed Aug 11, 2026

View reviewed changes

waleedlatif1 merged commit fff6606 into staging Aug 11, 2026
30 checks passed

waleedlatif1 deleted the folder-toolbar-header branch August 11, 2026 01:38

This was referenced Aug 11, 2026

v0.8.0: new workflow UI, v2 API, salesforce JWT, provenance improvements, incidentio tools, block retries #6533

Closed

v0.8.0: desktop app, workflow UI, v2 endpoints #6606

Merged

Uh oh!

Conversation

waleedlatif1 commented Aug 11, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-apps Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

waleedlatif1 commented Aug 11, 2026

Uh oh!

waleedlatif1 commented Aug 11, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Aug 11, 2026

Uh oh!

waleedlatif1 commented Aug 11, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Aug 11, 2026

Uh oh!

waleedlatif1 commented Aug 11, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Aug 11, 2026 •

edited

Loading

cursor Bot commented Aug 11, 2026 •

edited

Loading

greptile-apps Bot commented Aug 11, 2026 •

edited

Loading