-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix(auth): stop offering account creation when registration is disabled #6484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import { buildAuthCrossLink } from '@/app/(auth)/auth-redirect' | ||
| import { AuthHeader, AuthNavPrompt } from '@/app/(auth)/components' | ||
|
|
||
| interface RegistrationDisabledProps { | ||
| /** Post-auth destination the visitor arrived with, already validated. */ | ||
| callbackUrl: string | null | ||
| isInviteFlow: boolean | ||
| } | ||
|
|
||
| /** | ||
| * The signup page under DISABLE_REGISTRATION. Visitors reach it from a stale | ||
| * link, a bookmark, or an invitation, so it wears the same shell as the form it | ||
| * replaces and carries the post-auth destination over to login — an invited | ||
| * visitor who lands here can still sign in and end up back on their invitation | ||
| * rather than losing it. | ||
| */ | ||
| export function RegistrationDisabled({ callbackUrl, isInviteFlow }: RegistrationDisabledProps) { | ||
| return ( | ||
| <div className='space-y-6'> | ||
| <AuthHeader | ||
| title='Account creation is disabled' | ||
| description='Ask your admin to create an account for you.' | ||
| /> | ||
| <AuthNavPrompt | ||
| prompt='Already have an account?' | ||
| href={buildAuthCrossLink('/login', { callbackUrl, isInviteFlow })} | ||
| linkLabel='Sign in' | ||
| /> | ||
| </div> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { createSearchParamsCache, parseAsString } from 'nuqs/server' | ||
|
|
||
| /** | ||
| * The redirect signals the signup page carries. Read once to decide where a | ||
| * visitor goes after authenticating, never written, so every parser is nullable | ||
| * with no default — absent means "no destination", which is a real state rather | ||
| * than something to fall back from. | ||
| */ | ||
| const signupParsers = { | ||
| redirect: parseAsString, | ||
| callbackUrl: parseAsString, | ||
| inviteFlow: parseAsString, | ||
| } as const | ||
|
|
||
| /** `invite_flow` on the wire; camelCase for destructuring. */ | ||
| const signupUrlKeys = { urlKeys: { inviteFlow: 'invite_flow' } } as const | ||
|
|
||
| /** | ||
| * Server-side reader for the signup page. The client form reads these same keys | ||
| * through `useSearchParams` (the read-once auth-signal carve-out), so the wire | ||
| * keys here and in `signup-form.tsx` must stay in step. | ||
| */ | ||
| export const signupSearchParamsCache = createSearchParamsCache(signupParsers, signupUrlKeys) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.