Skip to content

fix(emails): align the schedule-disabled email with the standard template rhythm - #6477

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/schedule-disabled-email-styling
Aug 10, 2026
Merged

fix(emails): align the schedule-disabled email with the standard template rhythm#6477
waleedlatif1 merged 1 commit into
stagingfrom
fix/schedule-disabled-email-styling

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • The schedule-disabled email was the only template with two dividers — one boxing in a stray "Fix the problem, then turn the schedule back on." line above the CTA. Every other email goes greeting → body → info box → button → one divider → footnote.
  • Dropped the extra divider and folded that instruction into the lead paragraph, so it reads "It will not run again until you fix the problem and turn it back on."
  • No style/token changes — just the same structure the rest of the emails already use.

Type of Change

  • Bug fix

Testing

Rendered the template locally and diffed the HTML against credits-exhausted / welcome — divider count now matches. render-notifications.test.ts passes (6/6), type-check clean.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 9, 2026 11:54pm

Request Review

@cursor

cursor Bot commented Aug 9, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Notification email copy and layout only; no runtime logic, APIs, or data handling.

Overview
The schedule-disabled notification email is updated so its layout matches other notification templates: greeting → body → reason info box → CTA → one divider → footnote.

The extra divider and standalone “fix the problem…” line after the info box are removed. That guidance is merged into the opening body so it ends with “until you fix the problem and turn it back on” instead of splitting “turn it back on” from the follow-up sentence.

Reviewed by Cursor Bugbot for commit 017766c. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Aligns the schedule-disabled notification with the standard email layout while preserving its existing guidance.

  • Folds the remediation instruction into the lead paragraph.
  • Removes the extra divider and duplicate instruction before the optional workflow button.

Confidence Score: 5/5

The PR appears safe to merge.

The change only consolidates existing recipient guidance and removes redundant presentation markup; no blocking or independently actionable failure remains.

Important Files Changed

Filename Overview
apps/sim/components/emails/notifications/schedule-disabled-email.tsx Consolidates duplicate remediation copy and removes an extra divider without changing notification logic or supported reason handling.

Reviews (1): Last reviewed commit: "fix(emails): align the schedule-disabled..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit cdeb83d into staging Aug 10, 2026
30 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/schedule-disabled-email-styling branch August 10, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant