improvement(admin): move user row actions into an overflow menu with confirm modals by waleedlatif1 · Pull Request #6384 · simstudioai/sim

waleedlatif1 · 2026-08-07T19:05:31Z

Summary

Moved Reset password, Promote/Demote, and Ban/Unban into a ... overflow menu (RowActionsMenu, same as Secrets/API keys) so the actions column stops wrapping to two lines
Kept Impersonate as the only inline button since it's the action we use most
Ban now opens a ChipConfirmModal (destructive) with the optional reason as a ChipModalField, replacing the ad-hoc inline two-step row
Promote/Demote now opens the same confirm modal instead of firing immediately

Type of Change

Improvement

Testing

Tested manually

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-08-07T19:05:40Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Aug 7, 2026 8:06pm

cursor · 2026-08-07T19:07:01Z

PR Summary

Medium Risk
Changes how platform admins trigger ban, role changes, and password resets in the UI, but adds confirmation for destructive actions and does not alter the underlying mutation APIs.

Overview
Admin user rows no longer show a wide strip of inline buttons. Impersonate stays as a single inline Chip; reset password, promote/demote, and ban/unban move into the shared RowActionsMenu overflow pattern (same as API keys/secrets), with a narrower actions column.

Ban and promote/demote now require ChipConfirmModal confirmation instead of inline two-step ban UI or immediate role mutations. Ban keeps an optional reason via ChipModalField; pending actions track user ids so refetches can refresh the email shown in the modal. Reset password still runs from the menu but surfaces success/error via toast and a brief inline “sending…” message instead of button label churn.

Inline error banners for ban/role/reset are trimmed where errors are shown in modals or toasts; unban/impersonate errors still use the section error line.

^{Reviewed by Cursor Bugbot for commit 731f1d7. Configure here.}

greptile-apps · 2026-08-07T19:07:49Z

Greptile Summary

The PR consolidates less-frequent user administration operations into an overflow menu while retaining impersonation inline.

Adds confirmation modals for ban and role changes.
Moves password-reset progress outside the closing menu and reports completion through toasts.
Replaces the inline ban-reason workflow with a modal field.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/settings/components/admin/admin.tsx	Reworks administrative row actions and confirmation flows; the previously reported feedback issues are fixed, invalid, accepted, or unrelated to PR-introduced behavior.

_{Reviews (9): Last reviewed commit: "improvement(admin): align the role confi..." | Re-trigger Greptile}

waleedlatif1 · 2026-08-07T19:10:59Z

@greptile

waleedlatif1 · 2026-08-07T19:11:00Z

@cursor review

waleedlatif1 · 2026-08-07T19:17:35Z

@greptile

waleedlatif1 · 2026-08-07T19:17:36Z

@cursor review

waleedlatif1 · 2026-08-07T19:23:08Z

@greptile

waleedlatif1 · 2026-08-07T19:23:09Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit c8ce9d7. Configure here.}

waleedlatif1 · 2026-08-07T19:32:50Z

@greptile

waleedlatif1 · 2026-08-07T19:32:51Z

@cursor review

waleedlatif1 · 2026-08-07T19:38:36Z

@greptile

waleedlatif1 · 2026-08-07T19:38:37Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

1 issue from previous review remains unresolved.

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit f7c1ffc. Configure here.}

waleedlatif1 · 2026-08-07T19:45:49Z

@greptile

waleedlatif1 · 2026-08-07T19:45:50Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit e429457. Configure here.}

waleedlatif1 · 2026-08-07T19:52:08Z

@greptile

…confirm modals

…'s inverse

…use patterns

waleedlatif1 · 2026-08-07T20:05:59Z

@greptile

waleedlatif1 · 2026-08-07T20:06:00Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 731f1d7. Configure here.}

vercel Bot temporarily deployed to Preview August 7, 2026 19:05 Inactive

greptile-apps Bot reviewed Aug 7, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/settings/components/admin/admin.tsx Outdated

cursor Bot reviewed Aug 7, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/settings/components/admin/admin.tsx Outdated

Comment thread apps/sim/app/workspace/[workspaceId]/settings/components/admin/admin.tsx

vercel Bot temporarily deployed to Preview August 7, 2026 19:10 Inactive

vercel Bot temporarily deployed to Preview August 7, 2026 19:17 Inactive

cursor Bot reviewed Aug 7, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/settings/components/admin/admin.tsx

vercel Bot temporarily deployed to Preview August 7, 2026 19:23 Inactive

cursor Bot reviewed Aug 7, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview August 7, 2026 19:32 Inactive

vercel Bot temporarily deployed to Preview August 7, 2026 19:38 Inactive

cursor Bot reviewed Aug 7, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/settings/components/admin/admin.tsx

greptile-apps Bot reviewed Aug 7, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/settings/components/admin/admin.tsx

cursor Bot reviewed Aug 7, 2026

View reviewed changes

waleedlatif1 force-pushed the admin-user-row-actions-menu branch from f7c1ffc to e429457 Compare August 7, 2026 19:45

vercel Bot temporarily deployed to Preview August 7, 2026 19:45 Inactive

greptile-apps Bot reviewed Aug 7, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/settings/components/admin/admin.tsx

cursor Bot reviewed Aug 7, 2026

View reviewed changes

greptile-apps Bot reviewed Aug 7, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/settings/components/admin/admin.tsx

waleedlatif1 added 8 commits August 7, 2026 13:05

improvement(admin): move user row actions into an overflow menu with …

5a93b2e

…confirm modals

fix(admin): surface password reset status outside the actions menu

f0803b0

fix(admin): surface ban and role change errors inside the confirm modal

a2874b2

fix(admin): reset the ban mutation when opening the confirm modal

2be09b6

improvement(admin): simplify the user row actions after review passes

c6ead9d

fix(admin): show password reset progress while the request is in flight

f93de34

fix(admin): confirm the role change the admin chose, not the live row…

d36229d

…'s inverse

improvement(admin): align the role confirm and reset feedback with ho…

731f1d7

…use patterns

waleedlatif1 force-pushed the admin-user-row-actions-menu branch from e429457 to 731f1d7 Compare August 7, 2026 20:05

vercel Bot temporarily deployed to Preview August 7, 2026 20:06 Inactive

cursor Bot reviewed Aug 7, 2026

View reviewed changes

waleedlatif1 merged commit 73bac1a into staging Aug 7, 2026
30 checks passed

waleedlatif1 deleted the admin-user-row-actions-menu branch August 7, 2026 20:17

Uh oh!

Conversation

waleedlatif1 commented Aug 7, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-apps Bot commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Aug 7, 2026 •

edited

Loading

cursor Bot commented Aug 7, 2026 •

edited

Loading

greptile-apps Bot commented Aug 7, 2026 •

edited

Loading