Skip to content

chore(trigger): upsize task size - #6007

Merged
icecrasher321 merged 2 commits into
stagingfrom
staging-v12
Jul 28, 2026
Merged

chore(trigger): upsize task size #6007
icecrasher321 merged 2 commits into
stagingfrom
staging-v12

Conversation

@icecrasher321

Copy link
Copy Markdown
Collaborator

Summary

Upsize trigger task sizes to deal with larger file loads. Minor forking tag hover UI improvement.

Type of Change

  • Other: Infra Scaling

Testing

N/A

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 28, 2026 5:35pm

Request Review

@cursor

cursor Bot commented Jul 28, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Infra scaling changes affect core workflow/schedule execution and fork copy reliability/cost; UI changes are localized with new tests.

Overview
Upsizes several Trigger.dev background tasks to handle heavier workloads: fork-content-copy and knowledge-connector-sync use large-2x, while schedule-execution and workflow-execution move to medium-2x. fork-content-copy documents why the larger machine matters (in-memory copy of rows, KB chunks, embeddings, blobs; single attempt so OOM is not retried).

Fork activity event badges get hover tooltips for non-success states (Queued, In progress, failure reason, partial-copy warnings); successful completed rows stay tooltip-free.

Activity log rows without expandable details render as a plain div instead of a disabled button, so badge/cell tooltips still receive pointer events.

Reviewed by Cursor Bugbot for commit fbe8971. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Upsizes Trigger.dev machine presets for heavier background work and fixes fork/activity-log badge hover tooltips on non-expandable rows.

  • workflow-execution and schedule-execution move from medium-1x to medium-2x
  • knowledge-connector-sync and new fork-content-copy use large-2x
  • Activity log renders non-expandable rows as plain divs so nested hover tooltips work
  • Fork activity panel adds status tooltips on Event badges, with unit coverage

Confidence Score: 5/5

Safe to merge; machine preset upsizes use valid Trigger.dev sizes and the activity-row/tooltip changes are covered by focused tests.

Diff only increases known machine presets and fixes pointer-event swallowing for tooltips on inert activity rows, with matching unit tests and no contract or security surface changes.

Important Files Changed

Filename Overview
apps/sim/background/workflow-execution.ts Bumps async workflow execution task machine from medium-1x to medium-2x.
apps/sim/background/schedule-execution.ts Bumps schedule-execution task options machine from medium-1x to medium-2x.
apps/sim/background/knowledge-connector-sync.ts Upsizes connector sync worker from large-1x to large-2x for larger file loads.
apps/sim/background/fork-content-copy.ts Pins fork content copy to large-2x with comment explaining memory/OOM risk under maxAttempts 1.
apps/sim/app/workspace/[workspaceId]/settings/components/activity-log/activity-log.tsx Non-expandable rows use a div instead of a disabled button so descendant hover tooltips receive pointer events.
apps/sim/ee/workspace-forking/components/fork-activity-panel/fork-activity-panel.tsx Wraps Event badges with status tooltips (queued/in progress/failed/warnings) using truncated error/message text.
apps/sim/ee/workspace-forking/components/fork-activity-panel/fork-activity-panel.test.tsx Adds jsdom tests for badge tooltips and non-disabled non-expandable rows.

Reviews (1): Last reviewed commit: "chore(trigger): upsize tasks" | Re-trigger Greptile

@icecrasher321
icecrasher321 merged commit 3df01e7 into staging Jul 28, 2026
20 checks passed
@icecrasher321
icecrasher321 deleted the staging-v12 branch July 28, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant