Skip to content

docs(e2e): add settings maintenance guidance#5899

Merged
BillLeoutsakosvl346 merged 2 commits into
e2e/settings-playwrightfrom
e2e/07b-maintenance-guidance
Jul 23, 2026
Merged

docs(e2e): add settings maintenance guidance#5899
BillLeoutsakosvl346 merged 2 commits into
e2e/settings-playwrightfrom
e2e/07b-maintenance-guidance

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • add a canonical settings E2E maintenance decision guide with accurate contract/spec ownership
  • add thin automatic Cursor, Claude, and generic-agent discovery pointers
  • modernize the settings-page procedure for the unified registry, workspace surface, standalone planes, renderers, and server route gates
  • link the operational E2E README to the maintenance guide

Scope

This is Stage A only. It intentionally keeps the temporary e2e/settings-playwright pull-request target and transition paragraph unchanged so this child PR receives the complete CI workflow. After this PR merges, the temporary target will be removed in a direct umbrella commit validated by PR #5773 to staging.

Verification

  • git diff --check
  • IDE lints: clean
  • bun run skills:check (31 generated skills synchronized)
  • parsed Cursor/Claude rule frontmatter and verified representative app/platform-authz path matches
  • verified all changed guidance links resolve
  • two fresh Claude Fable 5 Thinking High implementation review cycles: accepted with no remaining defects
  • two fresh GPT-5.6 Sol High implementation review cycles: accepted with no remaining defects

Runtime source is unchanged, so the prior five-repeat stability gate remains valid; this PR's required Lint and Test, Build App, and Settings E2E jobs provide the authoritative complete verification.

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Jul 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Jul 23, 2026 9:04pm

Request Review

@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds settings E2E maintenance guidance and agent-discovery pointers.

  • Documents which literal browser contracts and focused test projects correspond to settings navigation, authorization, credentials, workflows, and personas.
  • Updates settings-page guidance for the shared registry, standalone planes, workspace rendering, route gates, and shell ownership.
  • Links the operational E2E README and agent instruction surfaces to the new maintenance guide.

Confidence Score: 5/5

The documentation-only pull request appears safe to merge with no actionable defects identified.

The new guide’s referenced files, anchors, test projects, commands, settings architecture paths, and agent-rule scopes align with the current repository, and no runtime source behavior changes.

Important Files Changed

Filename Overview
apps/sim/e2e/MAINTENANCE.md Adds a coherent decision guide whose referenced contracts, specifications, README anchors, and orchestrated test boundaries align with the repository.
apps/sim/e2e/README.md Adds a valid relative link from the E2E runbook to the settings maintenance guide.
.claude/skills/add-settings-page/SKILL.md Modernizes the settings-page procedure around the unified registry, plane renderers, server route gates, tests, and browser contracts.
.claude/rules/sim-settings-pages.md Updates settings architecture guidance to reflect shared panels, standalone shells, registry metadata, and current unsaved-change ownership.
.claude/rules/sim-settings-e2e.md Adds correctly scoped Claude discovery guidance for settings-affecting Sim and platform-authorization changes.
.cursor/rules/sim-settings-e2e.mdc Adds Cursor rule metadata and guidance consistent with established repository rule syntax and current settings paths.
apps/sim/AGENTS.md Adds a concise settings E2E maintenance pointer to the app-level testing instructions.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Settings-related change] --> B{Observable contract changes?}
  B -->|Yes| C[Update product code]
  C --> D[Update matching literal E2E contract or workflow proof]
  D --> E[Run affected unit tests]
  E --> F[Run focused orchestrated Playwright project]
  B -->|No, implementation-only| G[Keep acceptance expectations unchanged]
  G --> E
  F --> H[Required CI remains authoritative]
Loading

Reviews (1): Last reviewed commit: "docs(e2e): add settings maintenance guid..." | Re-trigger Greptile

Co-authored-by: Cursor <cursoragent@cursor.com>
@BillLeoutsakosvl346
BillLeoutsakosvl346 merged commit e37ad74 into e2e/settings-playwright Jul 23, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant