fix(slack): allow empty status to clear the assistant status indicator#5827
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview The tool had Reviewed by Cursor Bugbot for commit 024192e. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThis PR allows Slack assistant status indicators to be cleared with an omitted or empty status.
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(slack): allow empty status to clear ..." | Re-trigger Greptile |
Summary
slack_set_statusdeclaredstatusasrequired: true/user-or-llm, so the shared required-param validator (tools/utils.ts) treated an empty string as missing and threw "Status is required for Slack Set Assistant Status" — the empty-string-clear path documented in the tool's own description could never reach Slackstatusnon-required so an omitted or empty value passes validation. The request body builder already sendsstatus: params.status ?? '', and Slack'sassistant.threads.setStatustreats an emptystatusas "clear the status indicator"SlackSetStatusParams.statusto matchstatussubblock was alreadyrequired: falseNote: the docs row in
apps/docs/content/docs/en/integrations/slack.mdxis generated, butbun run generate-docscurrently produces a broken result locally (truncates slack.mdx from 1873 to 15 lines, drops all MANUAL-CONTENT blocks, deletes the 13*-service-account.mdxpages, and rewrites ~15 unrelated integration pages). I reverted that and hand-applied only the single table row a correct regen would emit. The generator looks like it is running against an incomplete registry — worth a separate look.Type of Change
Testing
bun run type-checkclean.vitest run tools/utils.test.ts serializer/tests/dual-validation.test.ts— 40 passed.bun run lintandbun run check:api-validation:strictpass.Checklist