Skip to content

fix(ui): tuck notification stack below modal and dropdown menus#5779

Merged
waleedlatif1 merged 1 commit into
stagingfrom
worktree-fix+toast-zindex-below-modal
Jul 20, 2026
Merged

fix(ui): tuck notification stack below modal and dropdown menus#5779
waleedlatif1 merged 1 commit into
stagingfrom
worktree-fix+toast-zindex-below-modal

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Notifications (toasts) were rendering on top of open modals and the workspace dropdown menu because --z-toast (500) sat above --z-modal (200) and --z-popover (300) in the shared z-index scale
  • Moved the toast/notification layer to --z-toast: 150 so it's ambient: above page content and editor drawers (--z-dropdown: 100), but below the modal and every transient popper (menus, selects, popovers, tooltips)
  • Single-token change in globals.css — all toasts, modals, and dropdown menus consume these tokens as the single source of truth, so no component code changes

Type of Change

  • Bug fix

Testing

Traced every --z-toast, --z-modal, and --z-popover consumer: the toast stack and modal are both portaled to document.body (shared stacking context, so pure z compares), and the workspace switcher uses DropdownMenu (--z-popover, 300). Verified the only other --z-toast consumers — the landing skip-link (still above the z-50 navbar) and an off-screen drag ghost — are unaffected at 150.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jul 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 20, 2026 10:33pm

Request Review

@cursor

cursor Bot commented Jul 20, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single global z-index token change with no logic changes; minor risk that edge cases relying on toasts above everything could behave differently.

Overview
Fixes toasts and the notification stack painting above open modals and dropdown menus by lowering --z-toast from 500 to 150 in the shared z-index scale in globals.css.

Toasts stay ambient: above page content and --z-dropdown (100), but below --z-modal (200) and transient poppers (--z-popover, tooltips, etc.). The comment block documents that ordering. No component changes—everything reads these CSS variables.

Reviewed by Cursor Bugbot for commit fd8b8ab. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fd8b8ab. Configure here.

Comment thread apps/sim/app/_styles/globals.css
@greptile-apps

greptile-apps Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR changes the shared notification layer ordering in the Sim UI. The main changes are:

  • Lowers --z-toast from 500 to 150.
  • Keeps notifications above page content and dropdown-level drawers.
  • Places notifications below modals, menus, popovers, and tooltips.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
apps/sim/app/_styles/globals.css Lowers the shared toast z-index while preserving the intended ordering among page, modal, popover, and tooltip layers.

Reviews (1): Last reviewed commit: "fix(ui): tuck notification stack below m..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit d71e348 into staging Jul 20, 2026
20 checks passed
@waleedlatif1
waleedlatif1 deleted the worktree-fix+toast-zindex-below-modal branch July 20, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant