-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix(helm): close blocker/real-gap findings from Helm chart best-practices audit #5555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
02b06df
fix(helm): close blocker/real-gap findings from Helm chart best-pract…
waleedlatif1 a28efb9
fix(helm): move copilot's static config out of the ESO-required Secret
waleedlatif1 27d7743
fix(helm): don't shadow copilot's existingSecret with envDefaults
waleedlatif1 80e931d
fix(helm): key copilot's existingSecret check off its own secret.crea…
waleedlatif1 fd364c2
fix(helm): checksum/secret annotation on copilot ignores ESO-sourced …
waleedlatif1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| {{- if and .Values.externalSecrets.enabled .Values.copilot.enabled .Values.copilot.server.secret.create }} | ||
| # ExternalSecret for copilot server credentials (syncs from external secret managers) | ||
| # | ||
| # Mirrors external-secret-app.yaml: the data list is generated by iterating every | ||
| # non-empty entry in externalSecrets.remoteRefs.copilot. sim.copilot.validate fails | ||
| # template rendering if a required key (or any non-empty copilot.server.env key) is | ||
| # missing a matching remoteRefs.copilot entry, so a misconfiguration surfaces at | ||
| # `helm template` time instead of a container starting with an empty value. | ||
| apiVersion: external-secrets.io/{{ .Values.externalSecrets.apiVersion | default "v1beta1" }} | ||
| kind: ExternalSecret | ||
| metadata: | ||
| name: {{ include "sim.copilot.envSecretName" . }} | ||
| namespace: {{ .Release.Namespace }} | ||
| labels: | ||
| {{- include "sim.copilot.labels" . | nindent 4 }} | ||
| spec: | ||
| refreshInterval: {{ .Values.externalSecrets.refreshInterval | quote }} | ||
| secretStoreRef: | ||
| name: {{ required "externalSecrets.secretStoreRef.name is required when externalSecrets.enabled=true" .Values.externalSecrets.secretStoreRef.name }} | ||
| kind: {{ .Values.externalSecrets.secretStoreRef.kind | default "ClusterSecretStore" }} | ||
| target: | ||
| name: {{ include "sim.copilot.envSecretName" . }} | ||
| creationPolicy: Owner | ||
| data: | ||
| {{- range $secretKey, $ref := .Values.externalSecrets.remoteRefs.copilot }} | ||
| {{- if $ref }} | ||
| {{- if kindIs "string" $ref }} | ||
| - secretKey: {{ $secretKey }} | ||
| remoteRef: | ||
| key: {{ $ref }} | ||
| {{- else if kindIs "map" $ref }} | ||
| - secretKey: {{ $secretKey }} | ||
| remoteRef: | ||
| {{- toYaml $ref | nindent 8 }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.