fix(gmail): stop wrapping draft/send HTML body in per-paragraph tags by waleedlatif1 · Pull Request #5479 · simstudioai/sim

waleedlatif1 · 2026-07-07T17:18:39Z

Summary

Gmail drafts/sends always include an HTML alternative part alongside plain text — Gmail renders that HTML part, so it's what actually shows up in the compose window
plainTextToHtml was wrapping each paragraph in  tags, which carries default paragraph margins that Gmail flags as "formatting" (requiring the "Remove formatting" button to strip)
Switched to a single white-space: pre-wrap block, which preserves line breaks/blank lines without introducing any margin/styling

Type of Change

Bug fix

Testing

Updated unit tests in apps/sim/tools/gmail/utils.test.ts; full suite passes (5716/5716)

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-07-07T17:18:48Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 7, 2026 5:20pm

cursor · 2026-07-07T17:18:48Z

PR Summary

Low Risk
Localized change to HTML generation for plain-text email bodies with updated tests; no auth or API contract changes.

Overview
Gmail draft/send HTML for plain-text bodies no longer wraps each paragraph in  tags. plainTextToHtml now escapes the full body and turns every newline into   inside a single <body>, so blank lines become consecutive   without default paragraph margins that Gmail treats as “formatting.”

Comments in utils.ts explain why   was chosen over  or CSS white-space. Unit tests in utils.test.ts were updated for plainTextToHtml, buildSimpleEmailMessage, and buildMimeMessage HTML parts.

^{Reviewed by Cursor Bugbot for commit e3a2a5e. Configure here.}

white-space: pre-wrap has inconsistent email-client support (including Gmail for non-Google accounts per caniemail.com); is the client-agnostic standard for plain-text-to-HTML line breaks.

greptile-apps · 2026-07-07T17:21:31Z

Greptile Summary

Fixes Gmail's "Remove formatting" prompt by replacing the per-paragraph -tag approach in plainTextToHtml with a flat  -per-newline strategy. The  margins are what Gmail flags as rich formatting;   tags preserve visual line breaks without introducing any margin/styling that email clients would treat as formatting.

plainTextToHtml now normalises line endings and replaces every \n with  , wrapping the result in a bare <body> — no  splits, no CSS properties.
All dependent tests (buildSimpleEmailMessage, buildMimeMessage) updated to match the new HTML shape.

Confidence Score: 5/5

Safe to merge — the change is confined to a single utility function and its tests, with no side effects on surrounding logic.

The rewrite of plainTextToHtml is minimal and mechanically correct: escapeHtml runs before the newline replacement, so HTML injection from user content is not affected. The new br approach is a well-understood, universally supported HTML email primitive. All related tests pass and cover the key contract.

No files require special attention.

Important Files Changed

Filename	Overview
apps/sim/tools/gmail/utils.ts	Replaces per-paragraph `<p>` tag wrapping with flat `<br>` newline conversion in `plainTextToHtml`; JSDoc updated to explain the client-compatibility rationale.
apps/sim/tools/gmail/utils.test.ts	Tests updated to assert `<br>` line breaks and absence of `<p>` tags; the `buildMimeMessage` attachment assertion is now a weaker `toContain('Hello')` but still valid.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["plainTextToHtml(body)"] --> B["Normalize line endings"]
    B --> C["Escape HTML special chars"]
    C --> D["Replace newlines with br tags"]
    D --> E["Wrap in bare HTML document"]
    E --> F["Return HTML string"]
    style A fill:#4A90D9,color:#fff
    style E fill:#27AE60,color:#fff

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A["plainTextToHtml(body)"] --> B["Normalize line endings"]
    B --> C["Escape HTML special chars"]
    C --> D["Replace newlines with br tags"]
    D --> E["Wrap in bare HTML document"]
    E --> F["Return HTML string"]
    style A fill:#4A90D9,color:#fff
    style E fill:#27AE60,color:#fff

_{Reviews (2): Last reviewed commit: "fix(gmail): use instead of CSS whit..." | Re-trigger Greptile}

waleedlatif1 · 2026-07-07T17:25:23Z

@greptile

waleedlatif1 · 2026-07-07T17:25:24Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit e3a2a5e. Configure here.}

fix(gmail): stop wrapping draft/send HTML body in per-paragraph tags

82c1f35

fix(gmail): use instead of CSS white-space for line breaks

e3a2a5e

white-space: pre-wrap has inconsistent email-client support (including Gmail for non-Google accounts per caniemail.com); is the client-agnostic standard for plain-text-to-HTML line breaks.

vercel Bot temporarily deployed to Preview July 7, 2026 17:20 Inactive

greptile-apps Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread apps/sim/tools/gmail/utils.ts

cursor Bot reviewed Jul 7, 2026

View reviewed changes

waleedlatif1 merged commit 954fdd8 into staging Jul 7, 2026
18 checks passed

waleedlatif1 deleted the fix/gmail-draft-html-formatting branch July 7, 2026 17:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(gmail): stop wrapping draft/send HTML body in per-paragraph <p> tags#5479

fix(gmail): stop wrapping draft/send HTML body in per-paragraph <p> tags#5479
waleedlatif1 merged 2 commits into
stagingfrom
fix/gmail-draft-html-formatting

waleedlatif1 commented Jul 7, 2026

Uh oh!

vercel Bot commented Jul 7, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Jul 7, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Jul 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

waleedlatif1 commented Jul 7, 2026

Uh oh!

waleedlatif1 commented Jul 7, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

waleedlatif1 commented Jul 7, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-apps Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

waleedlatif1 commented Jul 7, 2026

Uh oh!

waleedlatif1 commented Jul 7, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Jul 7, 2026 •

edited

Loading

cursor Bot commented Jul 7, 2026 •

edited

Loading

greptile-apps Bot commented Jul 7, 2026 •

edited

Loading