Skip to content

feat(aws): expand SES/STS/Secrets Manager tool coverage, fix API alignment gaps #5450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 6 commits into from
Jul 7, 2026
Merged

feat(aws): expand SES/STS/Secrets Manager tool coverage, fix API alignment gaps #5450

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
900f02f
feat(aws): expand SES/STS/Secrets Manager tool coverage, fix API alig…
waleedlatif1 Jul 6, 2026
62137c3
fix(aws): address review findings on SES config/identity and Secrets …
waleedlatif1 Jul 6, 2026
86594a7
fix(ses): correct json input types for tags/dkimSigningAttributes
waleedlatif1 Jul 6, 2026
b94cf1d
fix(ses): stop coercing switch string 'false' to true in create_confi…
waleedlatif1 Jul 6, 2026
777b435
fix(sts): stop double-parsing assume_role session tags input
waleedlatif1 Jul 6, 2026
6656103
fix(sts): supply placeholder credentials to the unauthenticated client
waleedlatif1 Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(ses): stop coercing switch string 'false' to true in create_confi… 
…guration_set

Boolean('false') evaluates to true, so turning off the
reputationMetricsEnabled or sendingEnabled switch sent the opposite of
the user's choice to SES. Match the established === 'true' string
comparison pattern used elsewhere in the codebase.
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Jul 6, 2026
commit b94cf1d3775da5f9cfa86f2a7e9934718992cf7c
6 changes: 4 additions & 2 deletions apps/sim/blocks/blocks/ses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,8 +593,10 @@ export const SESBlock: BlockConfig<ToolResponse> = {
if (rest.tlsPolicy) result.tlsPolicy = rest.tlsPolicy
if (rest.sendingPoolName) result.sendingPoolName = rest.sendingPoolName
if (rest.reputationMetricsEnabled != null)
result.reputationMetricsEnabled = Boolean(rest.reputationMetricsEnabled)
if (rest.sendingEnabled != null) result.sendingEnabled = Boolean(rest.sendingEnabled)
result.reputationMetricsEnabled =
rest.reputationMetricsEnabled === true || rest.reputationMetricsEnabled === 'true'
if (rest.sendingEnabled != null)
result.sendingEnabled = rest.sendingEnabled === true || rest.sendingEnabled === 'true'
if (rest.suppressedReasons) result.suppressedReasons = rest.suppressedReasons
if (rest.tags) result.tags = rest.tags
break
Expand Down
Loading