Skip to content

improvement(tables): show error message tooltip on errored workflow and enrichment cells #5449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheodoreSpeaks merged 1 commit into from
Jul 7, 2026
+21 −6
Merged

improvement(tables): show error message tooltip on errored workflow and enrichment cells #5449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions .../app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/cells/cell-render.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ import { SimResourceCell, type SimResourceType } from './sim-resource-cell'
export type CellRenderKind =
// Workflow-output cells
| { kind: 'value'; text: string }
| { kind: 'block-error' }
| { kind: 'block-error'; message: string }
| { kind: 'running' }
| { kind: 'pending-upstream' }
| { kind: 'queued' }
| { kind: 'cancelled' }
| { kind: 'error' }
| { kind: 'error'; message: string | null }
| { kind: 'waiting'; labels: string[] }
| { kind: 'not-found' }
| { kind: 'no-output' }
Expand Down Expand Up @@ -68,7 +68,7 @@ export function resolveCellRender({
const blockRunning = blockId ? (exec?.runningBlockIds?.includes(blockId) ?? false) : false
const groupHasBlockErrors = !!(exec?.blockErrors && Object.keys(exec.blockErrors).length > 0)

if (blockError) return { kind: 'block-error' }
if (blockError) return { kind: 'block-error', message: blockError }

const inFlight =
exec?.status === 'running' || exec?.status === 'queued' || exec?.status === 'pending'
Expand Down Expand Up @@ -103,7 +103,7 @@ export function resolveCellRender({
return { kind: 'waiting', labels: waitingOnLabels }
}
if (exec?.status === 'cancelled') return { kind: 'cancelled' }
if (exec?.status === 'error') return { kind: 'error' }
if (exec?.status === 'error') return { kind: 'error', message: exec.error }
// Enrichment ran to completion but matched nothing → "Not found".
if (isEnrichmentOutput && exec?.status === 'completed') return { kind: 'not-found' }
// Workflow output: the group's run completed but this block produced no
Expand Down Expand Up @@ -249,12 +249,27 @@ export function CellRender({ kind, isEditing }: CellRenderProps): React.ReactEle
)

case 'block-error':
case 'error':
case 'error': {
if (!kind.message) {
return (
<Wrap isEditing={isEditing}>
<StatusBadge status='error' />
</Wrap>
)
}
return (
<Wrap isEditing={isEditing}>
<StatusBadge status='error' />
<Tooltip.Root>
<Tooltip.Trigger asChild>
<span>
<StatusBadge status='error' />
</span>
</Tooltip.Trigger>
<Tooltip.Content side='top'>{kind.message}</Tooltip.Content>
</Tooltip.Root>
</Wrap>
)
}

case 'running':
return (
Expand Down
Loading