Feature/else access control permissions #529
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,178 @@ | ||
| import { and, eq } from 'drizzle-orm' | ||
| import { type NextRequest, NextResponse } from 'next/server' | ||
| import { getSession } from '@/lib/auth' | ||
| import { db } from '@/db' | ||
| import { permissions, type permissionTypeEnum, user, workspaceMember } from '@/db/schema' | ||
|
|
||
| // Extract the enum type from Drizzle schema | ||
| type PermissionType = (typeof permissionTypeEnum.enumValues)[number] | ||
|
|
||
| interface UpdatePermissionsRequest { | ||
| updates: Array<{ | ||
| userId: string | ||
| permissions: PermissionType // Single permission type instead of object with booleans | ||
| }> | ||
| } | ||
|
|
||
| // Helper function to fetch users with permissions for a workspace | ||
| async function getUsersWithPermissions(workspaceId: string) { | ||
| const usersWithPermissions = await db | ||
| .select({ | ||
| userId: user.id, | ||
| email: user.email, | ||
| name: user.name, | ||
| image: user.image, | ||
| permissionType: permissions.permissionType, | ||
| }) | ||
| .from(permissions) | ||
| .innerJoin(user, eq(permissions.userId, user.id)) | ||
| .where(and(eq(permissions.entityType, 'workspace'), eq(permissions.entityId, workspaceId))) | ||
| .orderBy(user.email) | ||
|
|
||
| // Since each user has only one permission, we can use the results directly | ||
| return usersWithPermissions.map((row) => ({ | ||
| userId: row.userId, | ||
| email: row.email, | ||
| name: row.name, | ||
| image: row.image, | ||
| permissionType: row.permissionType, | ||
| })) | ||
| } | ||
|
|
||
| /** | ||
| * GET /api/workspaces/[id]/permissions | ||
| * | ||
| * Retrieves all users who have permissions for the specified workspace. | ||
| * Returns user details along with their specific permissions. | ||
| * | ||
| * @param workspaceId - The workspace ID from the URL parameters | ||
| * @returns Array of users with their permissions for the workspace | ||
| */ | ||
| export async function GET(request: NextRequest, { params }: { params: Promise<{ id: string }> }) { | ||
| try { | ||
| const { id: workspaceId } = await params | ||
| const session = await getSession() | ||
|
|
||
| if (!session?.user?.id) { | ||
| return NextResponse.json({ error: 'Authentication required' }, { status: 401 }) | ||
| } | ||
|
|
||
| // Verify the current user has access to this workspace | ||
| const userMembership = await db | ||
| .select() | ||
| .from(workspaceMember) | ||
| .where( | ||
| and( | ||
| eq(workspaceMember.workspaceId, workspaceId), | ||
| eq(workspaceMember.userId, session.user.id) | ||
| ) | ||
| ) | ||
| .limit(1) | ||
|
|
||
| if (userMembership.length === 0) { | ||
| return NextResponse.json({ error: 'Workspace not found or access denied' }, { status: 404 }) | ||
| } | ||
|
|
||
| const result = await getUsersWithPermissions(workspaceId) | ||
|
|
||
| return NextResponse.json({ | ||
| users: result, | ||
| total: result.length, | ||
| }) | ||
| } catch (error) { | ||
| console.error('Error fetching workspace permissions:', error) | ||
| return NextResponse.json({ error: 'Failed to fetch workspace permissions' }, { status: 500 }) | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * PATCH /api/workspaces/[id]/permissions | ||
| * | ||
| * Updates permissions for existing workspace members. | ||
| * Only admin users can update permissions. | ||
| * | ||
| * @param workspaceId - The workspace ID from the URL parameters | ||
| * @param updates - Array of permission updates for users | ||
| * @returns Success message or error | ||
| */ | ||
| export async function PATCH(request: NextRequest, { params }: { params: Promise<{ id: string }> }) { | ||
| try { | ||
| const { id: workspaceId } = await params | ||
| const session = await getSession() | ||
|
|
||
| if (!session?.user?.id) { | ||
| return NextResponse.json({ error: 'Authentication required' }, { status: 401 }) | ||
| } | ||
|
|
||
| // Verify the current user has admin access to this workspace | ||
| const userPermissions = await db | ||
| .select() | ||
| .from(permissions) | ||
| .where( | ||
| and( | ||
| eq(permissions.userId, session.user.id), | ||
| eq(permissions.entityType, 'workspace'), | ||
| eq(permissions.entityId, workspaceId), | ||
| eq(permissions.permissionType, 'admin') | ||
| ) | ||
| ) | ||
| .limit(1) | ||
|
|
||
| if (userPermissions.length === 0) { | ||
| return NextResponse.json( | ||
| { error: 'Admin access required to update permissions' }, | ||
| { status: 403 } | ||
| ) | ||
| } | ||
|
|
||
| // Parse and validate request body | ||
| const body: UpdatePermissionsRequest = await request.json() | ||
|
|
||
| // Prevent users from modifying their own admin permissions | ||
| const selfUpdate = body.updates.find((update) => update.userId === session.user.id) | ||
| if (selfUpdate && selfUpdate.permissions !== 'admin') { | ||
| return NextResponse.json( | ||
| { error: 'Cannot remove your own admin permissions' }, | ||
| { status: 400 } | ||
| ) | ||
| } | ||
|
|
||
| // Process updates in a transaction | ||
| await db.transaction(async (tx) => { | ||
| for (const update of body.updates) { | ||
| // Delete existing permissions for this user and workspace | ||
| await tx | ||
| .delete(permissions) | ||
| .where( | ||
| and( | ||
| eq(permissions.userId, update.userId), | ||
| eq(permissions.entityType, 'workspace'), | ||
| eq(permissions.entityId, workspaceId) | ||
| ) | ||
| ) | ||
|
|
||
| // Insert the single new permission | ||
| await tx.insert(permissions).values({ | ||
| id: crypto.randomUUID(), | ||
| userId: update.userId, | ||
| entityType: 'workspace' as const, | ||
| entityId: workspaceId, | ||
| permissionType: update.permissions, | ||
| createdAt: new Date(), | ||
| updatedAt: new Date(), | ||
| }) | ||
| } | ||
| }) | ||
|
|
||
| const updatedUsers = await getUsersWithPermissions(workspaceId) | ||
|
|
||
| return NextResponse.json({ | ||
| message: 'Permissions updated successfully', | ||
| users: updatedUsers, | ||
| total: updatedUsers.length, | ||
| }) | ||
| } catch (error) { | ||
| console.error('Error updating workspace permissions:', error) | ||
| return NextResponse.json({ error: 'Failed to update workspace permissions' }, { status: 500 }) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: GET endpoint allows any workspace member to view all permissions - should be restricted to admins only for consistency with PATCH