PR: changes for migration#528
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
PR Summary
Major database schema update implementing a comprehensive permissions system with role-based access control and entity-level permissions.
- Added new
permission_typeenum andpermissionstable inapps/sim/db/migrations/0046_loose_blizzard.sqlwith admin/write/read access levels - Implemented unique constraint and btree indexes in permissions table for efficient access control lookups
- Added
permissionscolumn toworkspace_invitationtable for granular invitation control - Created foreign key relationships between permissions and user tables with proper cascade behaviors
- Set up optimized query patterns with composite indexes on (
entity_type,entity_id,user_id)
4 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
| userId: text('user_id') | ||
| .notNull() | ||
| .references(() => user.id, { onDelete: 'cascade' }), | ||
| entityType: text('entity_type').notNull(), // 'workspace', 'workflow', 'organization', etc. |
Contributor
There was a problem hiding this comment.
style: Consider adding a check constraint to validate entityType values to prevent invalid types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same PR as feature/access-control-permissions but just the db migration changes so we can do those first