fix/workflow-reload#526
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
PR Summary
Fixed workflow loading state synchronization by modifying initial state in apps/sim/stores/workflows/registry/store.ts to prevent incorrect workspace transitions during page reloads and direct URL navigation.
- Changed initial
isLoadingstate from false to true in workflow registry store to ensure proper loading states during workspace transitions - Improves handling of direct workflow URL navigation across different workspaces
- Prevents random workspace selection when reloading the page
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
b18293c to
127e70e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixed issue where it goes to random workspace when you click reload
Fixes # (issue)
Type of change
How Has This Been Tested?
Reloaded on different workflows. Also went to a different workspace, and pasted in the url of another workflow in a diff workspace and it worked.
Checklist:
bun run test)