improvement(access-controls): docs, terminology, fix delete bug#5141
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview In Access Control, the permission-group Blocks tab label Tools becomes Integrations and Triggers. The delete permission group confirmation is hoisted into a shared Risk: Display-name and copy only for blocks/docs, plus a small UI fix for delete confirmation; block Reviewed by Cursor Bugbot for commit c06f2ef. Configure here. |
Greptile SummaryThis PR makes three improvements to the access controls and terminology: renames the "Sim" block/trigger to "Sim Workspace Events" and the "Webhook" block to "Outgoing Webhook" across the codebase and docs for clarity, fixes a UX bug where clicking "Delete" on a permission group from the group detail view failed to show the confirmation modal, and relabels the "Tools" section header in the permission group modal to "Integrations and Triggers".
Confidence Score: 5/5Safe to merge — changes are scoped to display names, documentation text, and a straightforward UI bug fix with no data or logic risk. The delete confirmation modal fix is mechanical and correct: the JSX variable is hoisted above both return branches and included in both, so all delete paths now show the confirmation dialog. Rename changes are consistent across blocks, triggers, tests, and docs. No business logic, API contracts, or data models were altered. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User clicks Delete on group] --> B{Which view?}
B -->|Group detail view| C[handleDeleteClick sets deletingGroup]
B -->|Main list view| C
C --> D[deleteConfirmModal renders with open=true]
D --> E{User confirms?}
E -->|Yes| F[confirmDelete called]
E -->|No| G[setDeletingGroup null - Modal closes]
F --> H[deletePermissionGroup mutation]
H --> I[setDeletingGroup null]
I --> J{Was deleting viewingGroup?}
J -->|Yes| K[setViewingGroup null - Return to list]
J -->|No| L[Stay on current view]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[User clicks Delete on group] --> B{Which view?}
B -->|Group detail view| C[handleDeleteClick sets deletingGroup]
B -->|Main list view| C
C --> D[deleteConfirmModal renders with open=true]
D --> E{User confirms?}
E -->|Yes| F[confirmDelete called]
E -->|No| G[setDeletingGroup null - Modal closes]
F --> H[deletePermissionGroup mutation]
H --> I[setDeletingGroup null]
I --> J{Was deleting viewingGroup?}
J -->|Yes| K[setViewingGroup null - Return to list]
J -->|No| L[Stay on current view]
Reviews (1): Last reviewed commit: "improvement(access-controls): fix delete..." | Re-trigger Greptile |
Summary
Type of Change
Testing
Tested manually
Checklist