Skip to content

improvement(access-controls): docs, terminology, fix delete bug#5141

Merged
icecrasher321 merged 2 commits into
stagingfrom
improvement/access-controls-ux
Jun 19, 2026
Merged

improvement(access-controls): docs, terminology, fix delete bug#5141
icecrasher321 merged 2 commits into
stagingfrom
improvement/access-controls-ux

Conversation

@icecrasher321

Copy link
Copy Markdown
Collaborator

Summary

  • Rename block/trigger combos that were not doing the same thing, made confusing UI in permission group modal
  • Fix delete bug where clicking on delete did not ask for confirmation until back was clicked
  • Terminology / docs improvement

Type of Change

  • Other: UX Improvement

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jun 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Jun 19, 2026 8:44pm

Request Review

@cursor

cursor Bot commented Jun 19, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Mostly display names, docs, and a localized Access Control modal fix; no changes to block types, permissions logic, or runtime behavior.

Overview
Renames workflow blocks and triggers so similarly named pieces are easier to tell apart in the UI and docs: the outbound webhook_request block is now Outgoing Webhook (docs updated to match), and the workspace-events trigger is Sim Workspace Events instead of Sim. Tests assert the new display names.

In Access Control, the permission-group Blocks tab label Tools becomes Integrations and Triggers. The delete permission group confirmation is hoisted into a shared deleteConfirmModal so it renders on both the list and group detail views—fixing the bug where delete from a group detail did not show confirmation until navigating back.

Risk: Display-name and copy only for blocks/docs, plus a small UI fix for delete confirmation; block type IDs are unchanged.

Reviewed by Cursor Bugbot for commit c06f2ef. Configure here.

@greptile-apps

greptile-apps Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR makes three improvements to the access controls and terminology: renames the "Sim" block/trigger to "Sim Workspace Events" and the "Webhook" block to "Outgoing Webhook" across the codebase and docs for clarity, fixes a UX bug where clicking "Delete" on a permission group from the group detail view failed to show the confirmation modal, and relabels the "Tools" section header in the permission group modal to "Integrations and Triggers".

  • Terminology rename: Block/trigger names updated consistently across TypeScript configs, trigger definitions, tests, and MDX docs.
  • Delete bug fix: deleteConfirmModal is now defined once before both return branches and included in both the group-detail view and the main list view, so the confirmation dialog appears regardless of which view initiated the delete action.
  • Label fix: The block section header in the add-permissions modal now reads "Integrations and Triggers" instead of "Tools".

Confidence Score: 5/5

Safe to merge — changes are scoped to display names, documentation text, and a straightforward UI bug fix with no data or logic risk.

The delete confirmation modal fix is mechanical and correct: the JSX variable is hoisted above both return branches and included in both, so all delete paths now show the confirmation dialog. Rename changes are consistent across blocks, triggers, tests, and docs. No business logic, API contracts, or data models were altered.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/ee/access-control/components/access-control.tsx Fixes delete confirmation modal missing on the group-detail view; also relabels "Tools" section to "Integrations and Triggers". Logic is correct and DRY.
apps/sim/blocks/blocks/sim_workspace_event.ts Block name updated from "Sim" to "Sim Workspace Events" for clarity.
apps/sim/blocks/blocks/webhook_request.ts Block name updated from "Webhook" to "Outgoing Webhook" to distinguish it from incoming webhook triggers.
apps/sim/triggers/sim/workspace-event.ts Trigger name updated from "Sim" to "Sim Workspace Events" to match block rename.
apps/sim/triggers/sim/workspace-event.test.ts Test assertion updated to expect "Sim Workspace Events" name; correctly covers both block and trigger.
apps/docs/content/docs/en/workflows/blocks/webhook.mdx All occurrences of "Webhook block" updated to "Outgoing Webhook block" in documentation.
apps/docs/content/docs/en/workflows/triggers/sim.mdx All occurrences of "Sim trigger" updated to "Sim Workspace Events trigger" in documentation; FAQ entry rephrased for clarity.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User clicks Delete on group] --> B{Which view?}
    B -->|Group detail view| C[handleDeleteClick sets deletingGroup]
    B -->|Main list view| C
    C --> D[deleteConfirmModal renders with open=true]
    D --> E{User confirms?}
    E -->|Yes| F[confirmDelete called]
    E -->|No| G[setDeletingGroup null - Modal closes]
    F --> H[deletePermissionGroup mutation]
    H --> I[setDeletingGroup null]
    I --> J{Was deleting viewingGroup?}
    J -->|Yes| K[setViewingGroup null - Return to list]
    J -->|No| L[Stay on current view]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[User clicks Delete on group] --> B{Which view?}
    B -->|Group detail view| C[handleDeleteClick sets deletingGroup]
    B -->|Main list view| C
    C --> D[deleteConfirmModal renders with open=true]
    D --> E{User confirms?}
    E -->|Yes| F[confirmDelete called]
    E -->|No| G[setDeletingGroup null - Modal closes]
    F --> H[deletePermissionGroup mutation]
    H --> I[setDeletingGroup null]
    I --> J{Was deleting viewingGroup?}
    J -->|Yes| K[setViewingGroup null - Return to list]
    J -->|No| L[Stay on current view]
Loading

Reviews (1): Last reviewed commit: "improvement(access-controls): fix delete..." | Re-trigger Greptile

@icecrasher321 icecrasher321 merged commit 13b5d21 into staging Jun 19, 2026
16 checks passed
@waleedlatif1 waleedlatif1 deleted the improvement/access-controls-ux branch June 20, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant