The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docs	Ready	Preview, Comment	Jun 16, 2026 1:43am

PR Summary

Medium Risk
Very wide import-path refactor touches auth, billing, and security-adjacent code; wrong mock or import could change behavior. New admin/replica lookup is only used by the flag evaluator today but will matter once flags gate real features.

Overview
Splits deploy-time toggles from runtime feature flags. Everything that used to live in feature-flags.ts (isProd, isHosted, isBillingEnabled, etc.) moves to new env-flags.ts; importers, Vitest mocks (featureFlagsMock → envFlagsMock), CI validation, and testing docs are updated to match. Runtime behavior for those booleans should be unchanged—this is mostly a rename and module boundary.

Adds a new feature-flags.ts for gated, no-redeploy flags on hosted. getFeatureFlags() loads the feature-flags AppConfig profile (same fetchAppConfigProfile pattern as access-control) when AppConfig is enabled; otherwise each registered flag falls back to a typed env secret (global on/off only). isFeatureEnabled(flag, { userId, orgId }) evaluates rules (enabled, orgIds, userIds, admins) with lazy isPlatformAdmin on dbReplica and an optional isAdmin override. The FEATURE_FLAGS registry is empty in this PR—no product call sites yet.

Operator/docs support: Claude/Cursor add-feature-flag skills document how to register flags and gate via AppConfig vs secrets. feature-flags.test.ts covers parsing, fallbacks, and admin gating. isPlatformAdmin is added in super-user.ts for the admin clause.

^{Reviewed by Cursor Bugbot for commit c82faeb. Bugbot is set up for automated code reviews on this repo. Configure here.}

@greptile review

Greptile Summary

This PR introduces a runtime, AppConfig-backed feature flag system (lib/core/config/feature-flags.ts) with per-request gating by org id, user id, or admin role, and renames the existing env/deployment-detection module from feature-flags.ts → env-flags.ts, updating all 160+ importers, tests, and the shared mock.

• New flag engine: getFeatureFlags reads a feature-flags AppConfig profile (stale-while-revalidate, ~30 s TTL) and falls back to per-flag secrets when AppConfig is not configured. isFeatureEnabled evaluates clauses in order (enabled → userIds → orgIds → admins) with lazy DB-replica admin resolution that short-circuits once any earlier clause matches.
• env-flags.ts rename: All deployment-detection booleans (isProd, isHosted, isBillingEnabled, etc.) are moved verbatim; no logic changes. The shared test mock (featureFlagsMock → envFlagsMock) is renamed 1-to-1.
• isPlatformAdmin addition: Reads user.role from dbReplica for admin gating; correctly documented as bounded-stale and appropriate for feature (not auth) decisions.

Confidence Score: 4/5

The core flag engine is well-structured and the AppConfig caching layer is solid; the rename sweep is mechanically clean and TypeScript confirms all import paths resolve.

The new feature-flag module is a pure addition with no flags registered yet, so there is no production gating logic to regress. The 160+ import renames are mechanical and verified by tsc. The one open question is that normalizeRule stores empty rule objects ({}) for AppConfig entries whose keys are all unrecognized, which could silently swallow operator typos; it evaluates to false (safe), but the discarded config is invisible without server-side logging.

apps/sim/lib/core/config/feature-flags.ts — normalizeRule empty-object handling is worth a second look before any real flags are deployed.

Important Files Changed

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant Caller
    participant isFeatureEnabled
    participant getFeatureFlags
    participant fetchAppConfigProfile
    participant evaluate
    participant isPlatformAdmin

    Caller->>isFeatureEnabled: "isFeatureEnabled(flag, { userId, orgId })"
    isFeatureEnabled->>getFeatureFlags: getFeatureFlags()
    alt isAppConfigEnabled
        getFeatureFlags->>fetchAppConfigProfile: fetchAppConfigProfile(ids, parseConfig)
        note over fetchAppConfigProfile: Stale-while-revalidate cache (~30s TTL)
        fetchAppConfigProfile-->>getFeatureFlags: "FeatureFlagsConfig | null"
    else fallback path
        getFeatureFlags-->>getFeatureFlags: fallbackFlags() from env secrets
    end
    getFeatureFlags-->>isFeatureEnabled: "{ flags }"
    isFeatureEnabled->>evaluate: evaluate(flags[flag], ctx)
    note over evaluate: 1. rule.enabled?
    note over evaluate: 2. userId in userIds?
    note over evaluate: 3. orgId in orgIds?
    alt "rule.admins && no earlier match"
        evaluate->>isPlatformAdmin: isPlatformAdmin(userId) via dbReplica
        isPlatformAdmin-->>evaluate: boolean
    end
    evaluate-->>isFeatureEnabled: boolean
    isFeatureEnabled-->>Caller: boolean

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant Caller
    participant isFeatureEnabled
    participant getFeatureFlags
    participant fetchAppConfigProfile
    participant evaluate
    participant isPlatformAdmin

    Caller->>isFeatureEnabled: "isFeatureEnabled(flag, { userId, orgId })"
    isFeatureEnabled->>getFeatureFlags: getFeatureFlags()
    alt isAppConfigEnabled
        getFeatureFlags->>fetchAppConfigProfile: fetchAppConfigProfile(ids, parseConfig)
        note over fetchAppConfigProfile: Stale-while-revalidate cache (~30s TTL)
        fetchAppConfigProfile-->>getFeatureFlags: "FeatureFlagsConfig | null"
    else fallback path
        getFeatureFlags-->>getFeatureFlags: fallbackFlags() from env secrets
    end
    getFeatureFlags-->>isFeatureEnabled: "{ flags }"
    isFeatureEnabled->>evaluate: evaluate(flags[flag], ctx)
    note over evaluate: 1. rule.enabled?
    note over evaluate: 2. userId in userIds?
    note over evaluate: 3. orgId in orgIds?
    alt "rule.admins && no earlier match"
        evaluate->>isPlatformAdmin: isPlatformAdmin(userId) via dbReplica
        isPlatformAdmin-->>evaluate: boolean
    end
    evaluate-->>isFeatureEnabled: boolean
    isFeatureEnabled-->>Caller: boolean

_{Reviews (1): Last reviewed commit: "improvement(feature-flags): fallback is ..." | Re-trigger Greptile}