The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jun 12, 2026 7:02am

PR Summary

Low Risk
Mostly presentational component swaps and shared UI helpers; the expanded-cell editor change is localized UX/state behavior with no auth or data-model changes.

Overview
Standardizes tables UI on emcn chip controls (ChipInput, ChipDropdown) for column names, enrichment search/output names, find-in-table, and filter value entry; filter column/operator pickers move off hand-rolled dropdowns to ChipDropdown.

Validation and styling: field errors use the error prop on chip inputs instead of border class overrides; workflow/enrichment comboboxes stop passing error strings into ChipCombobox (which broke the options UI) and show separate messages; shared RequiredLabel / FieldError live in sidebar-fields with --text-error / text-caption tokens.

UX and perf fixes: expanded cell editing is split into a keyed ExpandedCellEditor so drafts survive row refetches while the popover stays open; memoized filter / aside props for Resource.Options / Resource.Header; CSV list upload derives uploading from uploadProgress; dead useTableRows hook removed. Minor refactors: ActionIconButton in the action bar, emcn close icons/buttons on enrichments sidebar.

^{Reviewed by Cursor Bugbot for commit 5bbc574. Configure here.}

Greptile Summary

This PR migrates all form-style inputs across the tables feature to the emcn chip component family (ChipInput, ChipDropdown, ChipCombobox) and performs a focused cleanup pass — fixing broken CSS variable references, extracting shared RequiredLabel/FieldError components, deduplicating ActionIconButton, and removing the dead useTableRows hook.

• UI migration: Input → ChipInput (with error boolean prop replacing className border overrides), hand-rolled dropdown pills → ChipDropdown, --text-danger/text-destructive → --text-error/text-caption throughout sidebars and filter rows.
• ExpandedCellEditor refactor: Extracted as a keyed child component so the textarea draft survives SSE/polling row refetches without being reset; memoization of filterConfig and handleToggleFilter prevents defeating React.memo on Resource.Options.
• Correctness fix: ChipCombobox's error string prop (which replaced the options list with the error message rather than styling the trigger) removed in workflow-sidebar and enrichment-config; errors now render as a separate FieldError element below the combobox.

Confidence Score: 4/5

Safe to merge; all changes are additive UI migrations and correctness fixes with no data-path or API-contract changes.

The ChipCombobox error-misuse fix, CSS variable correction, and ExpandedCellEditor keying are all improvements over the previous state. The only open question is the inline error paragraph in enrichment-config.tsx lacking the pl-0.5 spacing that FieldError provides, leaving a minor visual inconsistency. No regressions identified in the core table data or mutation paths.

enrichment-config.tsx — the input-mapping validation error paragraph should use FieldError for consistent padding.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph "New shared: sidebar-fields"
        RF[RequiredLabel]
        FE[FieldError]
    end

    subgraph "column-config-sidebar"
        CC[ColumnConfigBody] -->|imports| RF
        CC -->|imports| FE
        CC -->|ChipInput error=Boolean| CI1[ChipInput]
    end

    subgraph "workflow-sidebar"
        WS[WorkflowSidebarBody] -->|imports| RF
        WS -->|imports| FE
        WS -->|ChipInput error=Boolean| CI2[ChipInput]
        WS -->|error prop removed| CCB1[ChipCombobox]
        WS -->|renders below| FE
    end

    subgraph "enrichment-config"
        EC[EnrichmentConfig] -->|ChipInput error=Boolean| CI3[ChipInput]
        EC -->|error prop removed| CCB2[ChipCombobox]
        EC -->|inline p.text-error| ERR[error paragraph]
    end

    subgraph "table-filter"
        TF[FilterRuleRow] -->|was hand-rolled pill| CD1[ChipDropdown column]
        TF -->|was hand-rolled pill| CD2[ChipDropdown operator]
        TF -->|was raw input| CI4[ChipInput value]
    end

    subgraph "expanded-cell-popover"
        ECP[ExpandedCellPopover] -->|key=rowId:colKey| ECE[ExpandedCellEditor]
        ECE -->|useState initialValue| DV[draftValue preserved on SSE refetch]
    end

    subgraph "tables.tsx"
        T[Tables] -->|derived| UP[uploading = uploadProgress.total > 0]
        T -->|useMemo| FC[filterConfig stable ref]
        T -->|useMemo| HA[headerAside stable ref]
    end

_{Reviews (1): Last reviewed commit: "improvement(tables): migrate inputs to e..." | Re-trigger Greptile}