Skip to content

fix(docker): logger import#4988

Merged
icecrasher321 merged 1 commit into
stagingfrom
fix/docker-logger-exp
Jun 12, 2026
Merged

fix(docker): logger import#4988
icecrasher321 merged 1 commit into
stagingfrom
fix/docker-logger-exp

Conversation

@icecrasher321

Copy link
Copy Markdown
Collaborator

Summary

Logger import missing for new tripwire runtime support

Type of Change

  • Bug fix

Testing

N/A

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Jun 12, 2026 1:12am

Request Review

@cursor

cursor Bot commented Jun 12, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Build-only Dockerfile change for the db image; no runtime app logic changes beyond fixing a missing workspace dependency in that container.

Overview
Updates the database migration Docker image so the workspace packages/logger package is installed and copied into the final image, matching how @sim/utils and @sim/tsconfig are already handled.

In the deps stage, the Dockerfile now creates the logger package directory and copies packages/logger/package.json before bun install, so workspace resolution includes @sim/logger. In the runner stage, it copies the full packages/logger tree so @sim/db can load tx-tripwire, which imports @sim/logger at module load time.

Reviewed by Cursor Bugbot for commit d2eeadb. Configure here.

@greptile-apps

greptile-apps Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes a missing packages/logger dependency in the db Docker image, which was needed after tx-tripwire.ts introduced an @sim/logger import for the new transaction tripwire runtime support.

  • Adds packages/logger to the mkdir command and copies its package.json in the deps stage so bun install resolves @sim/logger (and its chalk transitive dep) into node_modules.
  • Copies the full packages/logger source tree into the runner stage, placed before packages/db to preserve Docker layer-cache ordering (logger changes less frequently than db).

Confidence Score: 5/5

Safe to merge — the change adds the missing logger package to the db Docker image, directly fixing a build-time import failure introduced by tx-tripwire.ts.

The fix correctly mirrors the existing pattern for utils and tsconfig: package.json is copied in the deps stage for bun install, and the full source tree is copied in the runner stage before packages/db to preserve layer-cache ordering. No logic changes and no other files are affected.

No files require special attention.

Important Files Changed

Filename Overview
docker/db.Dockerfile Adds packages/logger to both the deps and runner stages; correctly mirrors the existing pattern used for packages/utils and packages/tsconfig.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[base: oven/bun:1.3.13-alpine] --> B[deps stage]
    B --> C["mkdir packages/db, logger, tsconfig, utils"]
    C --> D[Copy package.json files for each package]
    D --> E["bun install - resolves @sim/logger and chalk"]
    E --> F[runner stage]
    F --> G[COPY node_modules from deps]
    G --> H[COPY packages/tsconfig]
    H --> I[COPY packages/utils]
    I --> J["COPY packages/logger - NEW"]
    J --> K[COPY packages/db - changes most frequently]
    K --> L[WORKDIR /app/packages/db]

    style J fill:#90ee90,stroke:#228B22
Loading

Reviews (1): Last reviewed commit: "fix(docker): logger import" | Re-trigger Greptile

@icecrasher321 icecrasher321 merged commit bf2a6cd into staging Jun 12, 2026
10 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/docker-logger-exp branch June 12, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant