The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jun 11, 2026 6:02pm

PR Summary

Low Risk
Small UI classification fix in the workflow canvas context menu with dedicated unit tests; no auth, API, or execution path changes.

Overview
Fixes the block right-click context menu mislabeling blocks pasted into loop/parallel subflows as positional triggers when they have no incoming edges yet, which hid Remove from Subflow (canRemoveFromSubflow requires !hasTriggerBlock).

Introduces isPositionalTriggerBlock: a top-level block with no incoming edges counts as a positional trigger; any block with parentId is never treated as one. workflow.tsx passes that helper into BlockMenu instead of inline edge counting. Unit tests cover nested/unconnected and regression paste-into-loop cases.

^{Reviewed by Cursor Bugbot for commit e8a8cd3. Configure here.}

@greptile

@cursor review

Greptile Summary

This PR fixes a bug where the "Remove from Subflow" context menu option was hidden for blocks that were copy-pasted into a loop or parallel subflow. Pasted blocks have parentId set immediately but no incoming edges yet, so the old inline heuristic (edges.filter(e => e.target === id).length === 0) classified them as positional triggers and suppressed the option.

• Extracts the trigger-classification heuristic into a named helper isPositionalTriggerBlock in workflow-canvas-helpers.ts, which short-circuits to false whenever the block has a parentId (i.e., is nested in a subflow).
• Replaces the inline edge-count expression in workflow.tsx with a call to the new helper.
• Adds a focused unit-test suite with six cases, including the explicit regression scenario (pasted, unconnected block inside a loop).

Confidence Score: 5/5

Safe to merge — the change is a well-scoped extraction of an existing inline expression into a named, tested helper with a clear correctness invariant.

The fix is minimal and focused: one new pure helper, one call-site substitution, and six unit tests including a regression case. The parentId guard is the correct property to check — it is set synchronously when a block is pasted into a subflow, before any edges are created, which is exactly the scenario that was broken. No existing behavior is altered for top-level blocks, and the BlockInfo type already carries parentId, so the type contract is satisfied at the call site.

No files require special attention.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Right-click block in canvas] --> B{contextMenuBlocks.length === 1?}
    B -- No --> C[isPositionalTrigger = false]
    B -- Yes --> D[isPositionalTriggerBlock called with block + edges]
    D --> E{block defined?}
    E -- No --> F[return false]
    E -- Yes --> G{block.parentId set?}
    G -- Yes: nested in subflow --> H[return false — never a trigger]
    G -- No: top-level --> I{any edge targets this block?}
    I -- Yes --> J[return false — has incoming connection]
    I -- No --> K[return true — positional trigger]
    H --> L{Show Remove from Subflow?}
    J --> L
    K --> L
    C --> L
    L -- isPositionalTrigger=true --> M[Hide Remove from Subflow]
    L -- isPositionalTrigger=false --> N[Show Remove from Subflow if parentId is set]

_{Reviews (2): Last reviewed commit: "fix(workflow): show Remove from Subflow ..." | Re-trigger Greptile}