refactor: use chonkie locally - #474
Closed
adiologydev wants to merge 2 commits into
Closed
Conversation
|
@adiologydev is attempting to deploy a commit to the Sim Studio Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
PR Summary
Major refactoring to enable local Chonkie integration and expand file parsing capabilities for improved self-hosting support.
- File parsing system expanded in
apps/sim/lib/file-parsers/with new TXT and MD parsers, but contains critical bugs inparseBufferimplementations and token counting - Removed cloud dependency by eliminating
CHONKIE_API_KEYfromapps/sim/lib/env.tsand updating imports from 'chonkie/cloud' to 'chonkie' apps/sim/lib/documents/document-processor.tssimplified by removing recipe and lang options, now using create() method for chunker instantiation- Both new parsers in
txt-parser.tsandmd-parser.tsneed significant improvements in error handling and buffer processing before production use
6 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile
Comment on lines
+262
to
+276
| it('should parse MD files successfully', async () => { | ||
| const expectedResult = { | ||
| content: 'Parsed MD content', | ||
| metadata: { | ||
| characterCount: 100, | ||
| tokenCount: 10, | ||
| }, | ||
| } | ||
|
|
||
| mockMdParseFile.mockResolvedValueOnce(expectedResult) | ||
| mockExistsSync.mockReturnValue(true) | ||
|
|
||
| const { parseFile } = await import('./index') | ||
| const result = await parseFile('/test/files/document.md') | ||
| }) |
Contributor
There was a problem hiding this comment.
logic: Missing assertion for result value - this test doesn't verify the parsing output matches expected result
Suggested change
| it('should parse MD files successfully', async () => { | |
| const expectedResult = { | |
| content: 'Parsed MD content', | |
| metadata: { | |
| characterCount: 100, | |
| tokenCount: 10, | |
| }, | |
| } | |
| mockMdParseFile.mockResolvedValueOnce(expectedResult) | |
| mockExistsSync.mockReturnValue(true) | |
| const { parseFile } = await import('./index') | |
| const result = await parseFile('/test/files/document.md') | |
| }) | |
| const result = await parseFile('/test/files/document.md') | |
| expect(result).toEqual(expectedResult) |
| logger.info('Parsing buffer, size:', buffer.length) | ||
|
|
||
| // Extract content | ||
| const result = await readFile(buffer, 'utf-8') |
Contributor
There was a problem hiding this comment.
logic: Critical error: readFile expects a file path, not a Buffer. Use buffer.toString('utf-8') instead.
Suggested change
| const result = await readFile(buffer, 'utf-8') | |
| const result = buffer.toString('utf-8') |
| logger.info('Parsing buffer, size:', buffer.length) | ||
|
|
||
| // Extract content | ||
| const result = await readFile(buffer, 'utf-8') |
Contributor
There was a problem hiding this comment.
logic: readFile cannot be used on a buffer. Use buffer.toString('utf-8') instead
Suggested change
| const result = await readFile(buffer, 'utf-8') | |
| const result = buffer.toString('utf-8') |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Uses chonkie locally instead of cloud to make self-hosting easy.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist:
bun run test)Security Considerations:
Additional Information:
Any additional information, configuration or data that might be necessary to reproduce the issue or use the feature.