improvement(ux): polish knowledge connector modal controls#4730
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview The add-connector modal adjusts layout/scroll sizing between type selection vs configuration, updates the source picker cards to use the standard Connector configuration controls drop explicit Reviewed by Cursor Bugbot for commit 2cb0571. Configure here. |
Greptile SummaryThis PR polishes the knowledge connector modal UI to align sizing, spacing, and icon treatment with workflow sub-block controls. All functional connector flows remain intact.
Confidence Score: 5/5All changes are scoped to visual styling and component variant choices; no data flow, state logic, or API paths are modified. The diff touches only className strings, a size prop removal, and a button-to-Button swap. All connector creation and editing logic is untouched, lint and type-check pass per the test plan, and the previously flagged truncation regression has been resolved. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[AddConnectorModal opens] --> B{step}
B -->|select-type| C[max-h-520px modal\npt-2 pb-3 body]
B -->|configure| D[h-80vh max-h-560px modal\npb-3 body]
C --> E[Search bar h-8 rounded-md]
E --> F[ConnectorTypeCard list\nmax-h-390px scrollable]
F --> G{filteredEntries?}
G -->|empty| H[Empty state text-caption]
G -->|results| I[Button variant=ghost\n+ direct Icon + name + description]
I --> J[onClick: setStep configure]
D --> K[Account Combobox\nno size=sm\nplaceholder: Select X account]
D --> L[Dynamic fields loop]
L --> M{field.type}
M -->|text/number| N[Input]
M -->|dropdown| O[Combobox\nno size=sm]
M -->|selector| P[ConnectorSelectorField\nno size=sm]
D --> Q{tagDefinitions?}
Q -->|yes| R[Flat checkbox rows\nno hover bg\nno outer container]
D --> S[Sync Frequency ButtonGroup]
D --> T[ModalFooter - Create connector]
Reviews (2): Last reviewed commit: "polish(kb-connectors): align connector m..." | Re-trigger Greptile |
f7a018a to
a109088
Compare
a109088 to
2cb0571
Compare
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2cb0571. Configure here.
Summary
Tests