fix(landing): remove cursor lerp causing laggy tracking in collaboration section#4727
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Updates the section’s Reviewed by Cursor Bugbot for commit d41e0ea. Configure here. |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
Greptile SummaryRemoves the
Confidence Score: 5/5Safe to merge — the change is scoped to a single landing page component and removes animation complexity without altering any data flow or business logic. The diff removes an rAF loop and two refs, replaces a lerp with a direct state update, and swaps a hardcoded string id for useId(). All three changes are straightforward with no side-effects on the rest of the app. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Mouse enters section] -->|onMouseEnter| B[setCursorPos + setIsHovering true]
B --> C[YouCursor renders at viewport coords]
D[Mouse moves over section] -->|onMouseMove| E[setCursorPos directly]
E --> C
F[Mouse leaves section] -->|onMouseLeave| G[setIsHovering false]
G --> H[YouCursor returns null]
subgraph Removed
direction TB
R1[rAF loop every frame] -->|lerp 0.3| R2[setCursorPos lagging behind]
end
style Removed fill:#fef2f2,stroke:#fca5a5
Reviews (3): Last reviewed commit: "fix(landing): remove cursor lerp causing..." | Re-trigger Greptile |
5bfdbe1 to
ac8b691
Compare
|
@greptile-apps Thanks — addressed the P2 JSDoc note in commit ddc2f69. Updated the SEO block to describe the new |
|
The JSDoc update looks good. The comment now accurately documents both IDs:
The distinction is clear and the rest of the implementation (direct position tracking, no animation loop) is all in order. LGTM. ✅ |
|
@greptile |
|
@cursor review |
40c1b4e to
d41e0ea
Compare
|
Reverted the biome |
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d41e0ea. Configure here.
Summary
CURSOR_LERP_FACTOR = 0.3) that smoothed the fakeYouCursorin the landing page collaboration section — caused visible trail/lag since the native cursor is hiddenhandleMouseMovenow sets cursor position directly for 1:1 tracking; dropped theuseEffectanimation loop and unused refscollaboration-headingid withuseId()to satisfy biome'suseUniqueElementIdsruleType of Change
Testing
Tested manually
Checklist