The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		May 20, 2026 9:05pm

PR Summary

Medium Risk
Touches core document processing and bulk upload paths by changing DB query shapes (joins and cached tag definition lookups), which could affect processing/billing behavior if the new joins or cached definitions are incorrect. Main intent is performance, but it changes how missing/deleted records are detected and how billing user IDs are sourced.

Overview
Reduces DB round-trips in knowledge document flows. Bulk document creation now loads knowledge_base_tag_definitions once per batch (and via the transaction executor) and resolves per-document tags via a new pure resolveDocumentTags helper.

processDocumentAsync now prefetches knowledge base config, workspace billing user, and document tag fields in a single document↔knowledge_base JOIN (removing separate reads), reuses the prefetched tag values for embedding rows, and updates the failure message/where-clause when the document/KB no longer exists.

Tests update the DB mock to support the new join-based prefetch used by processDocumentAsync.

^{Reviewed by Cursor Bugbot for commit 4ce7939. Configure here.}

Greptile Summary

This PR eliminates an N+1 query pattern in createDocumentRecords (bulk upload) by splitting the former processDocumentTags async function into loadTagDefinitions (single query, runs on the transaction connection) and resolveDocumentTags (pure synchronous function). Additionally, processDocumentAsync consolidates three separate SELECTs (KB config, workspace billing, document tag columns) into one JOIN, removing the secondary document read that happened deep inside the processing pipeline.

• createDocumentRecords: tag definitions are now loaded once per batch using the active transaction's executor, and only when at least one document carries documentTagsData; tag-free batches skip the query entirely.
• createSingleDocument: unchanged call-pattern — loadTagDefinitions runs outside the transaction with the global db pool, matching the pre-refactor behavior.
• processDocumentAsync: three queries collapsed into one JOIN across document, knowledge_base, and workspace; removes the import of getWorkspaceBilledAccountUserId (which already filtered on isNull(archivedAt), consistent with the new LEFT JOIN condition).

Confidence Score: 5/5

Safe to merge — a focused query consolidation with no behavioral regressions; error-handling and validation semantics are identical to the pre-refactor path.

The refactor correctly loads tag definitions once per batch on the transaction connection, eliminating the N+1 pattern without changing what happens when tags are invalid or missing. The workspace archivedAt filter in the new LEFT JOIN matches what getWorkspaceBilledAccountUserId already used, so billing lookups behave identically. The tag-free batch short-circuit is correct. No logic paths were broken.

No files require special attention.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant C as Caller
    participant CDR as createDocumentRecords (bulk)
    participant LTD as loadTagDefinitions
    participant RDT as resolveDocumentTags
    participant DB as Database (tx)

    C->>CDR: documents[], knowledgeBaseId
    CDR->>DB: SELECT 1 FROM knowledge_base FOR UPDATE
    CDR->>DB: "SELECT id FROM knowledge_base WHERE id=? (tx)"
    note over CDR: hasTaggedDocs check
    alt at least one doc has documentTagsData
        CDR->>LTD: knowledgeBaseId, tx
        LTD->>DB: "SELECT * FROM knowledge_base_tag_definitions WHERE kb_id=? (once, on tx)"
        DB-->>LTD: tag definitions[]
        LTD-->>CDR: "Map<name, TagDefinition>"
    else no tagged docs
        note over CDR: skip query entirely
    end
    loop for each document
        CDR->>RDT: tagData[], tagDefinitions (Map), requestId
        note over RDT: pure, synchronous
        RDT-->>CDR: ProcessedDocumentTags
    end
    CDR->>DB: INSERT documents[]
    DB-->>C: DocumentData[]

_{Reviews (2): Last reviewed commit: "lint" | Re-trigger Greptile}

@greptile

@cursor review