Skip to content

improvement(redis-cleanup): schedule, async workflow, hitl base64 cache cleanup #4646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 2 commits into from
May 17, 2026
+8 −0
Merged

improvement(redis-cleanup): schedule, async workflow, hitl base64 cache cleanup #4646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18b9ec9
improvement(redis-cleanup): schedule, async workflow, hitl bae64 cach…
icecrasher321 May 17, 2026
3a4d277
address comments
icecrasher321 May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/sim/background/schedule-execution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import {
import { preprocessExecution } from '@/lib/execution/preprocessing'
import { LoggingSession } from '@/lib/logs/execution/logging-session'
import { buildTraceSpans } from '@/lib/logs/execution/trace-spans/trace-spans'
import { cleanupExecutionBase64Cache } from '@/lib/uploads/utils/user-file-base64.server'
import {
executeWorkflowCore,
wasExecutionFinalizedByCore,
Expand Down Expand Up @@ -348,6 +349,8 @@ async function runWorkflowExecution({
})

throw error
} finally {
void cleanupExecutionBase64Cache(executionId)
}
}

Expand Down
3 changes: 3 additions & 0 deletions apps/sim/background/workflow-execution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { createTimeoutAbortController, getTimeoutErrorMessage } from '@/lib/core
import { preprocessExecution } from '@/lib/execution/preprocessing'
import { LoggingSession } from '@/lib/logs/execution/logging-session'
import { buildTraceSpans } from '@/lib/logs/execution/trace-spans/trace-spans'
import { cleanupExecutionBase64Cache } from '@/lib/uploads/utils/user-file-base64.server'
import {
executeWorkflowCore,
wasExecutionFinalizedByCore,
Expand Down Expand Up @@ -196,6 +197,8 @@ export async function executeWorkflowJob(payload: WorkflowExecutionPayload) {
})

throw error
} finally {
void cleanupExecutionBase64Cache(executionId)
}
})
}
Expand Down
2 changes: 2 additions & 0 deletions apps/sim/lib/workflows/executor/human-in-the-loop-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
import { compactBlockLogs, compactExecutionPayload } from '@/lib/execution/payloads/serializer'
import { preprocessExecution } from '@/lib/execution/preprocessing'
import { LoggingSession } from '@/lib/logs/execution/logging-session'
import { cleanupExecutionBase64Cache } from '@/lib/uploads/utils/user-file-base64.server'
import { executeWorkflowCore } from '@/lib/workflows/executor/execution-core'
import type { ExecutionEvent } from '@/lib/workflows/executor/execution-events'
import { ExecutionSnapshot } from '@/executor/execution/snapshot'
Expand Down Expand Up @@ -1363,6 +1364,7 @@ export class PauseResumeManager {
})
})
}
void cleanupExecutionBase64Cache(resumeExecutionId)
}

if (executionError || !result) {
Expand Down
Loading