improvement(workspace): allocate more space to name column in resource tables#4645
improvement(workspace): allocate more space to name column in resource tables#4645waleedlatif1 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Applies fixed widths to narrow metadata columns across workspace list pages (Files, Knowledge bases, KB documents/chunks, Tables, Scheduled Tasks, Logs) so the primary name/content column flexes and truncates less on wide screens. Reviewed by Cursor Bugbot for commit ca5b33e. Configure here. |
Greptile SummaryThis PR improves column layout across all resource tables by switching metadata columns (Size, Type, Created, Owner, etc.) from proportional weights to fixed pixel widths, allowing the primary name/content column to flex and absorb all remaining table space.
Confidence Score: 5/5Safe to merge — changes are purely presentational, scoped to column width declarations, and the core layout arithmetic in ResourceColGroup is mathematically sound. The width-distribution logic correctly subtracts all fixed-px columns and the checkbox from the total table width before dividing the remainder among flexible columns. No data, state, or API paths are touched. Every changed file only updates static COLUMNS constants. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[ResourceColGroup receives columns + hasCheckbox] --> B{col.widthPx set?}
B -- Yes --> C[Render col with fixed width px]
B -- No --> D[Assign flexible weight\ncolIdx==0 → 2.5x, else 1.0x × widthMultiplier]
D --> E[Compute flexibleTotal\nsum of all flexible weights]
E --> F[reservedPx = fixedPxTotal + checkboxPx]
F --> G[columnRatio = weight / flexibleTotal]
G --> H{reservedOffset > 0?}
H -- Yes --> I[calc percent% minus reservedOffset px]
H -- No --> J[columnPercent%]
Reviews (1): Last reviewed commit: "improvement(workspace): allocate more sp..." | Re-trigger Greptile |
Summary
Type of Change
Testing
Tested manually
Checklist