Skip to content

fix(knowledge): preserve scroll position when toggling tokenizer in chunk viewer #4643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waleedlatif1 wants to merge 2 commits into
base: staging
Choose a base branch
from
+26 −3
Open

fix(knowledge): preserve scroll position when toggling tokenizer in chunk viewer #4643

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8be4041
fix(knowledge): preserve scroll position when toggling tokenizer in c…
waleedlatif1 May 17, 2026
0e1e331
fix(knowledge): skip scroll restore on initial mount of chunk editor
waleedlatif1 May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions ...kspace/[workspaceId]/knowledge/[id]/[documentId]/components/chunk-editor/chunk-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use client'

import React, { useCallback, useEffect, useMemo, useRef, useState } from 'react'
import React, { useCallback, useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react'
import { Label, Switch } from '@/components/emcn'
import { isApiClientError } from '@/lib/api/client/errors'
import { requestJson } from '@/lib/api/client/request'
Expand Down Expand Up @@ -50,6 +50,8 @@ export function ChunkEditor({
onCreated,
}: ChunkEditorProps) {
const textareaRef = useRef<HTMLTextAreaElement>(null)
const tokenizedScrollRef = useRef<HTMLDivElement>(null)
const preservedScrollTopRef = useRef(0)
const { mutateAsync: updateChunk } = useUpdateChunk()
const { mutateAsync: createChunk } = useCreateChunk()

Expand Down Expand Up @@ -170,6 +172,24 @@ export function ChunkEditor({
[saveRef]
)

const hasToggledTokenizerRef = useRef(false)

const handleTokenizerChange = useCallback(
(value: boolean) => {
const source = tokenizerOn ? tokenizedScrollRef.current : textareaRef.current
preservedScrollTopRef.current = source?.scrollTop ?? 0
hasToggledTokenizerRef.current = true
setTokenizerOn(value)
},
[tokenizerOn]
)

useLayoutEffect(() => {
if (!hasToggledTokenizerRef.current) return
const target = tokenizerOn ? tokenizedScrollRef.current : textareaRef.current
if (target) target.scrollTop = preservedScrollTopRef.current
}, [tokenizerOn])
Comment thread
waleedlatif1 marked this conversation as resolved.

const tokenStrings = useMemo(() => {
if (!tokenizerOn || !editedContent) return []
return getTokenStrings(editedContent)
Expand All @@ -196,7 +216,10 @@ export function ChunkEditor({
}}
>
{tokenizerOn ? (
<div className='h-full w-full cursor-default overflow-y-auto whitespace-pre-wrap break-words p-6 font-sans text-[var(--text-body)] text-sm'>
<div
ref={tokenizedScrollRef}
className='h-full w-full cursor-default overflow-y-auto whitespace-pre-wrap break-words p-6 font-sans text-[var(--text-body)] text-sm'
>
{tokenStrings.map((token, index) => (
<span
key={index}
Expand Down Expand Up @@ -232,7 +255,7 @@ export function ChunkEditor({
<div className='flex items-center justify-between border-[var(--border)] border-t px-6 py-2.5'>
<TokenizerToggle
checked={tokenizerOn}
onCheckedChange={setTokenizerOn}
onCheckedChange={handleTokenizerChange}
hoveredTokenIndex={tokenizerOn ? hoveredTokenIndex : null}
/>
<span className='text-[var(--text-secondary)] text-caption'>
Expand Down
Loading