Skip to content

fix(files): fixed resource spacing on files directories pages#4618

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/fi
May 15, 2026
Merged

fix(files): fixed resource spacing on files directories pages#4618
waleedlatif1 merged 2 commits into
stagingfrom
fix/fi

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

  • fixed resource spacing on files directories pages
  • fix is primarily for large screens

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment May 15, 2026 7:48pm

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 15, 2026

PR Summary

Low Risk
Low risk: UI-only table column width calculation change plus a Turborepo patch upgrade; primary risk is minor layout regressions across resource list tables on different screen sizes.

Overview
Fixes resource list table spacing when row-selection checkboxes are present by switching the checkbox column to a fixed 52px width and adjusting other column widths via calc() so the total table width stays consistent.

Bumps turbo from 2.9.6 to 2.9.12 (including turbo.json schema and lockfile updates).

Reviewed by Cursor Bugbot for commit 53dbcc0. Configure here.

Comment thread turbo.json Outdated
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 15, 2026

Greptile Summary

This PR fixes a visual spacing issue on the files/directories pages by replacing a fractional weight for the checkbox column (CHECKBOX_WEIGHT = 0.4) with a fixed 52px pixel width, while distributing that offset proportionally across data columns via calc(). It also bumps turbo from 2.9.6 to 2.9.12 with matching lock file and schema URL updates.

  • resource.tsx: ResourceColGroup now pins the checkbox <col> to 52px and computes each data column as calc(X% - Ypx) where Y = 52 × columnRatio, ensuring columns still sum to 100% while preventing the checkbox from expanding on large screens.
  • package.json / bun.lock / turbo.json: turbo dependency and schema reference are updated from 2.9.6 → 2.9.12.

Confidence Score: 5/5

Safe to merge — the change is a straightforward visual fix scoped entirely to the colgroup width calculation.

The column width math is correct: the checkbox column is pinned to 52px, each data column subtracts its proportional share of that 52px via calc(), and the total always sums to 100%. The turbo bump is a minor version update with no API changes. No logic paths outside of rendering are affected.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/components/resource/resource.tsx Replaces fractional checkbox weight with a fixed 52px column width; data column widths use calc() to subtract their proportional share of the checkbox space, keeping total width at 100%.
package.json Bumps turbo from 2.9.6 to 2.9.12.
bun.lock Lock file updated to reflect turbo 2.9.12 and all its platform-specific binaries.
turbo.json Schema URL updated from v2-9-6 to v2-9-12 to match the installed turbo version.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[ResourceColGroup] --> B{hasCheckbox?}
    B -- Yes --> C["col width=52px fixed"]
    B -- Yes --> D["For each data column:\ncolumnRatio = weight / total\ncolumnPercent = ratio x 100\ncheckboxOffset = 52 x ratio\nwidth = calc(columnPercent% - checkboxOffset px)"]
    B -- No --> E["For each data column:\nwidth = columnPercent%"]
    C --> F["Columns sum: 52px + (100% - 52px) = 100%"]
    D --> F
    E --> G["Columns sum: 100%"]
Loading

Reviews (2): Last reviewed commit: "fix(build): align turbo schema version" | Re-trigger Greptile

Comment thread turbo.json Outdated
Co-authored-by: Cursor <cursoragent@cursor.com>
@waleedlatif1
Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1
Copy link
Copy Markdown
Collaborator Author

@cursor review

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 53dbcc0. Configure here.

@waleedlatif1 waleedlatif1 merged commit a64b338 into staging May 15, 2026
9 of 10 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/fi branch May 15, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant