feat(cloudwatch): add mute and unmute alarm operations#4602
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview Updates the Reviewed by Cursor Bugbot for commit bdb02ae. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryAdds
Confidence Score: 4/5The change is safe to merge; it adds two new isolated operations with no modifications to existing logic. All new code follows established patterns for auth, validation, AWS client lifecycle, and tool registration. The only findings are style-level: the Mute and Unmute contracts, TypeScript types, and tool files are structurally identical, creating maintenance surface that a shared base type/schema would eliminate. The contract files (cloudwatch-mute-alarm.ts, cloudwatch-unmute-alarm.ts) and types.ts contain duplicated definitions worth consolidating before they diverge. Important Files Changed
Sequence DiagramsequenceDiagram
participant UI as CloudWatch Block UI
participant Block as cloudwatch.ts (params fn)
participant Tool as mute_alarm / unmute_alarm tool
participant Route as /api/tools/cloudwatch/mute-alarm (or unmute-alarm)
participant AWS as AWS CloudWatch
UI->>Block: "operation=mute_alarm, alarmNames="a,b""
Block->>Block: split(",").map(trim).filter(Boolean) → ["a","b"]
Block->>Tool: "{ awsRegion, awsAccessKeyId, awsSecretAccessKey, alarmNames: ["a","b"] }"
Tool->>Route: "POST { region, accessKeyId, secretAccessKey, alarmNames }"
Route->>Route: checkInternalAuth()
Route->>Route: parseToolRequest (Zod validation)
Route->>AWS: DisableAlarmActionsCommand (or EnableAlarmActionsCommand)
AWS-->>Route: 200 OK (silent success even for unknown alarms)
Route-->>Tool: "{ success: true, output: { success: true, alarmNames } }"
Tool-->>Block: "{ success: true, output: { success: true, alarmNames } }"
Reviews (1): Last reviewed commit: "feat(cloudwatch): add mute and unmute al..." | Re-trigger Greptile |
Summary
mute_alarmoperation to the CloudWatch block (wrapsDisableAlarmActions)unmute_alarmoperation (wrapsEnableAlarmActions)Type of Change
Testing
Tested manually.
bun run lintclean.bun run check:api-validation:strictpasses (route baseline bumped 736 → 738).Checklist